On Monday 01 of June 2009 04:51:16 Wei Ni wrote:
> Hi, Takashi
> I'm a Nvidia engineer, we wish to support 8 channel HDMI audio for
> MCP78/7A.
>
> I attached the patch file, it based on the latest sound git tree,
> please check it.
>
Hi,
can you please run scripts/checkpatch.pl on the patches you submit? I'd help a
lot, thanks.
btw. here's the output (shortened):
total: 47 errors, 15 warnings, 349 lines checked
0001-Support-NVIDIA-8-channel-HDMI-audio.patch has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
> <<0001-Support-NVIDIA-8-channel-HDMI-audio.patch>>
>
> Thanks
> Wei.
>
> ---------------------------------------------------------------------------
>-------- This email message is for the sole use of the intended recipient(s)
> and may contain confidential information. Any unauthorized review, use,
> disclosure or distribution is prohibited. If you are not the intended
> recipient, please contact the sender by reply email and destroy all copies
> of the original message.
> ---------------------------------------------------------------------------
>--------
At Mon, 1 Jun 2009 07:07:30 +0200,
Marek Vasut wrote:
>
> On Monday 01 of June 2009 04:51:16 Wei Ni wrote:
> > Hi, Takashi
> > I'm a Nvidia engineer, we wish to support 8 channel HDMI audio for
> > MCP78/7A.
> >
> > I attached the patch file, it based on the latest sound git tree,
> > please check it.
> >
>
> Hi,
> can you please run scripts/checkpatch.pl on the patches you submit? I'd help a
> lot, thanks.
>
> btw. here's the output (shortened):
>
> total: 47 errors, 15 warnings, 349 lines checked
>
> 0001-Support-NVIDIA-8-channel-HDMI-audio.patch has style problems, please
> review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
Yep, that'll be helpful.
The changes there look almost fine after a quick glance, so please just
fix cosmetic coding issues and repost.
thanks,
Takashi
Hi, thanks for your comments.
I run scripts/checkpatch.pl on the new patches, it looks ok, it has 0 errors and 0 warnings.
I attached it.
Thanks
Wei.
-----Original Message-----
From: Marek Vasut [mailto:[email protected]]
Sent: Monday, June 01, 2009 1:08 PM
To: [email protected]
Cc: Wei Ni; Takashi Iwai; Peer Chen; linux-kernel; Pavel Hofman; akpm
Subject: Re: [alsa-devel] [PATCH] Support NVIDIA 8 channel HDMI audio
On Monday 01 of June 2009 04:51:16 Wei Ni wrote:
> Hi, Takashi
> I'm a Nvidia engineer, we wish to support 8 channel HDMI audio for
> MCP78/7A.
>
> I attached the patch file, it based on the latest sound git tree,
> please check it.
>
Hi,
can you please run scripts/checkpatch.pl on the patches you submit? I'd help a
lot, thanks.
btw. here's the output (shortened):
total: 47 errors, 15 warnings, 349 lines checked
0001-Support-NVIDIA-8-channel-HDMI-audio.patch has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
> <<0001-Support-NVIDIA-8-channel-HDMI-audio.patch>>
>
> Thanks
> Wei.
>
> ---------------------------------------------------------------------------
>-------- This email message is for the sole use of the intended recipient(s)
> and may contain confidential information. Any unauthorized review, use,
> disclosure or distribution is prohibited. If you are not the intended
> recipient, please contact the sender by reply email and destroy all copies
> of the original message.
> ---------------------------------------------------------------------------
>--------
At Mon, 1 Jun 2009 16:47:53 +0800,
Wei Ni wrote:
>
> Hi, thanks for your comments.
> I run scripts/checkpatch.pl on the new patches, it looks ok, it has 0 errors and 0 warnings.
> I attached it.
Thanks! I applied now to sound git tree.
Takashi
>
> Thanks
> Wei.
>
>
> -----Original Message-----
> From: Marek Vasut [mailto:[email protected]]
> Sent: Monday, June 01, 2009 1:08 PM
> To: [email protected]
> Cc: Wei Ni; Takashi Iwai; Peer Chen; linux-kernel; Pavel Hofman; akpm
> Subject: Re: [alsa-devel] [PATCH] Support NVIDIA 8 channel HDMI audio
>
> On Monday 01 of June 2009 04:51:16 Wei Ni wrote:
> > Hi, Takashi
> > I'm a Nvidia engineer, we wish to support 8 channel HDMI audio for
> > MCP78/7A.
> >
> > I attached the patch file, it based on the latest sound git tree,
> > please check it.
> >
>
> Hi,
> can you please run scripts/checkpatch.pl on the patches you submit? I'd help a
> lot, thanks.
>
> btw. here's the output (shortened):
>
> total: 47 errors, 15 warnings, 349 lines checked
>
> 0001-Support-NVIDIA-8-channel-HDMI-audio.patch has style problems, please
> review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> > <<0001-Support-NVIDIA-8-channel-HDMI-audio.patch>>
> >
> > Thanks
> > Wei.
> >
> > ---------------------------------------------------------------------------
> >-------- This email message is for the sole use of the intended recipient(s)
> > and may contain confidential information. Any unauthorized review, use,
> > disclosure or distribution is prohibited. If you are not the intended
> > recipient, please contact the sender by reply email and destroy all copies
> > of the original message.
> > ---------------------------------------------------------------------------
> >--------
>
>
> [2 0001-Support-NVIDIA-8-channel-HDMI-audio.patch <application/octet-stream (base64)>]
>