2022-04-24 17:28:42

by Sergey Shtylyov

Subject: Re: [PATCH -next] ata: palmld: fix return value check in palmld_pata_probe()

Hello!

You should CC: me on the PATA driver patches, not Bart -- he no longer maintains
the PATA drivers.

On 4/24/22 12:34 PM, Yang Yingliang wrote:

> If devm_platform_ioremap_resource() fails, it never return
> NULL pointer, replace the check with IS_ERR().
>
> Fixes: 57bf0f5a162d ("ARM: pxa: use pdev resource for palmld mmio")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Yang Yingliang <[email protected]>
[...]

Reviewed-by: Sergey Shtylyov <[email protected]>

MBR, Sergey

2022-04-25 13:48:41

by Yang Yingliang

Subject: Re: [PATCH -next] ata: palmld: fix return value check in palmld_pata_probe()

On 2022/4/25 0:55, Sergey Shtylyov wrote:
> Hello!
>
> You should CC: me on the PATA driver patches, not Bart -- he no longer maintains
> the PATA drivers.
OK.

Thanks,
Yang
>
> On 4/24/22 12:34 PM, Yang Yingliang wrote:
>
>> If devm_platform_ioremap_resource() fails, it never return
>> NULL pointer, replace the check with IS_ERR().
>>
>> Fixes: 57bf0f5a162d ("ARM: pxa: use pdev resource for palmld mmio")
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: Yang Yingliang <[email protected]>
> [...]
>
> Reviewed-by: Sergey Shtylyov <[email protected]>
>
> MBR, Sergey
> .