2020-09-16 06:49:42

by Johnny Chuang

Subject: [PATCH] Input: elants_i2c - fix typo for an attribute to show calibration count

Fixed typo for command from 0xE0 to 0xD0.

commit cf520c643012 ("Input: elants_i2c - provide an attribute
to show calibration count")

There is an non-touch case by non-calibration after update firmware.
Elan could know calibrate or not by calibration count.
The value of '0xffff' means we didn't calibrate after update firmware.
If calibrate success, it will plus one and change to '0x0000'.

Signed-off-by: Johnny Chuang <[email protected]>
---
drivers/input/touchscreen/elants_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index c8d7bdd..50c3482 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -90,7 +90,7 @@
/* FW read command, 0x53 0x?? 0x0, 0x01 */
#define E_ELAN_INFO_FW_VER 0x00
#define E_ELAN_INFO_BC_VER 0x10
-#define E_ELAN_INFO_REK 0xE0
+#define E_ELAN_INFO_REK 0xD0
#define E_ELAN_INFO_TEST_VER 0xE0
#define E_ELAN_INFO_FW_ID 0xF0
#define E_INFO_OSR 0xD6
--
2.7.4

2020-09-16 18:06:43

by Dmitry Torokhov

Subject: Re: [PATCH] Input: elants_i2c - fix typo for an attribute to show calibration count

On Wed, Sep 16, 2020 at 02:46:23PM +0800, Johnny Chuang wrote:
> Fixed typo for command from 0xE0 to 0xD0.
>
> commit cf520c643012 ("Input: elants_i2c - provide an attribute
> to show calibration count")
>
> There is an non-touch case by non-calibration after update firmware.
> Elan could know calibrate or not by calibration count.
> The value of '0xffff' means we didn't calibrate after update firmware.
> If calibrate success, it will plus one and change to '0x0000'.
>
> Signed-off-by: Johnny Chuang <[email protected]>

Applied, thank you.

--
Dmitry