2020-09-18 19:41:54

by Bhaumik Bhatt

Subject: [PATCH v3 1/3] bus: mhi: Fix entries based on Kconfig coding style

Kconfig coding style mandates use of tabs for the configuration
definition and an additional two spaces for the help text. Make the
required changes to the MHI Kconfig adhering to those guidelines.

Signed-off-by: Bhaumik Bhatt <[email protected]>
---
drivers/bus/mhi/Kconfig | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig
index a8bd9bd..6677ccc 100644
--- a/drivers/bus/mhi/Kconfig
+++ b/drivers/bus/mhi/Kconfig
@@ -6,9 +6,9 @@
#

config MHI_BUS
- tristate "Modem Host Interface (MHI) bus"
- help
- Bus driver for MHI protocol. Modem Host Interface (MHI) is a
- communication protocol used by the host processors to control
- and communicate with modem devices over a high speed peripheral
- bus or shared memory.
+ tristate "Modem Host Interface (MHI) bus"
+ help
+ Bus driver for MHI protocol. Modem Host Interface (MHI) is a
+ communication protocol used by the host processors to control
+ and communicate with modem devices over a high speed peripheral
+ bus or shared memory.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2020-09-18 20:33:17

by Randy Dunlap

Subject: Re: [PATCH v3 1/3] bus: mhi: Fix entries based on Kconfig coding style

On 9/18/20 12:39 PM, Bhaumik Bhatt wrote:
> Kconfig coding style mandates use of tabs for the configuration
> definition and an additional two spaces for the help text. Make the
> required changes to the MHI Kconfig adhering to those guidelines.
>
> Signed-off-by: Bhaumik Bhatt <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> drivers/bus/mhi/Kconfig | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig
> index a8bd9bd..6677ccc 100644
> --- a/drivers/bus/mhi/Kconfig
> +++ b/drivers/bus/mhi/Kconfig
> @@ -6,9 +6,9 @@
> #
>
> config MHI_BUS
> - tristate "Modem Host Interface (MHI) bus"
> - help
> - Bus driver for MHI protocol. Modem Host Interface (MHI) is a
> - communication protocol used by the host processors to control
> - and communicate with modem devices over a high speed peripheral
> - bus or shared memory.
> + tristate "Modem Host Interface (MHI) bus"
> + help
> + Bus driver for MHI protocol. Modem Host Interface (MHI) is a
> + communication protocol used by the host processors to control
> + and communicate with modem devices over a high speed peripheral
> + bus or shared memory.
>


--
~Randy

2020-09-21 14:00:51

by Manivannan Sadhasivam

Subject: Re: [PATCH v3 1/3] bus: mhi: Fix entries based on Kconfig coding style

On Fri, Sep 18, 2020 at 12:39:50PM -0700, Bhaumik Bhatt wrote:
> Kconfig coding style mandates use of tabs for the configuration
> definition and an additional two spaces for the help text. Make the
> required changes to the MHI Kconfig adhering to those guidelines.
>
> Signed-off-by: Bhaumik Bhatt <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
> drivers/bus/mhi/Kconfig | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig
> index a8bd9bd..6677ccc 100644
> --- a/drivers/bus/mhi/Kconfig
> +++ b/drivers/bus/mhi/Kconfig
> @@ -6,9 +6,9 @@
> #
>
> config MHI_BUS
> - tristate "Modem Host Interface (MHI) bus"
> - help
> - Bus driver for MHI protocol. Modem Host Interface (MHI) is a
> - communication protocol used by the host processors to control
> - and communicate with modem devices over a high speed peripheral
> - bus or shared memory.
> + tristate "Modem Host Interface (MHI) bus"
> + help
> + Bus driver for MHI protocol. Modem Host Interface (MHI) is a
> + communication protocol used by the host processors to control
> + and communicate with modem devices over a high speed peripheral
> + bus or shared memory.
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>