2020-09-19 02:29:43

by Zhang Changzhong

Subject: [PATCH net-next] net: mventa: remove unused variable 'dummy' in mvneta_mib_counters_clear()

Fixes the following W=1 kernel build warning(s):

drivers/net/ethernet/marvell/mvneta.c:754:6: warning:
variable 'dummy' set but not used [-Wunused-but-set-variable]
754 | u32 dummy;
| ^~~~~

This variable is not used in function mvneta_mib_counters_clear(), so
remove it to avoid build warning.

Signed-off-by: Zhang Changzhong <[email protected]>
---
drivers/net/ethernet/marvell/mvneta.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index f75e05e..4694242 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -751,13 +751,12 @@ static void mvneta_txq_inc_put(struct mvneta_tx_queue *txq)
static void mvneta_mib_counters_clear(struct mvneta_port *pp)
{
int i;
- u32 dummy;

/* Perform dummy reads from MIB counters */
for (i = 0; i < MVNETA_MIB_LATE_COLLISION; i += 4)
- dummy = mvreg_read(pp, (MVNETA_MIB_COUNTERS_BASE + i));
- dummy = mvreg_read(pp, MVNETA_RX_DISCARD_FRAME_COUNT);
- dummy = mvreg_read(pp, MVNETA_OVERRUN_FRAME_COUNT);
+ mvreg_read(pp, (MVNETA_MIB_COUNTERS_BASE + i));
+ mvreg_read(pp, MVNETA_RX_DISCARD_FRAME_COUNT);
+ mvreg_read(pp, MVNETA_OVERRUN_FRAME_COUNT);
}

/* Get System Network Statistics */
--
2.9.5

2020-09-20 21:19:44

by David Miller

Subject: Re: [PATCH net-next] net: mventa: remove unused variable 'dummy' in mvneta_mib_counters_clear()

From: Zhang Changzhong <[email protected]>
Date: Sat, 19 Sep 2020 10:26:51 +0800

> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/marvell/mvneta.c:754:6: warning:
> variable 'dummy' set but not used [-Wunused-but-set-variable]
> 754 | u32 dummy;
> | ^~~~~
>
> This variable is not used in function mvneta_mib_counters_clear(), so
> remove it to avoid build warning.
>
> Signed-off-by: Zhang Changzhong <[email protected]>

Applied.