2020-09-21 21:41:45

by Sowjanya Komatineni

[permalink] [raw]
Subject: [PATCH v6 1/3] media: i2c: imx274: Fix Y_OUT_SIZE register setting

As per Sony IMX274 Y_OUT_SIZE should be the height of effective
image output from the sensor which are the actual total lines
sent over MIPI CSI to receiver.

So, Y_OUT_SIZE should be same as crop height and this patch fixes it.

Signed-off-by: Sowjanya Komatineni <[email protected]>
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index 6011cec..a4b9dfd 100644
--- a/drivers/media/i2c/imx274.c
+++ b/drivers/media/i2c/imx274.c
@@ -1163,7 +1163,7 @@ static int imx274_apply_trimming(struct stimx274 *imx274)
(-imx274->crop.top / 2) : (imx274->crop.top / 2);
v_cut = (IMX274_MAX_HEIGHT - imx274->crop.height) / 2;
write_v_size = imx274->crop.height + 22;
- y_out_size = imx274->crop.height + 14;
+ y_out_size = imx274->crop.height;

err = imx274_write_mbreg(imx274, IMX274_HMAX_REG_LSB, hmax, 2);
if (!err)
--
2.7.4


2020-09-22 08:34:47

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH v6 1/3] media: i2c: imx274: Fix Y_OUT_SIZE register setting

On Mon, Sep 21, 2020 at 02:39:37PM -0700, Sowjanya Komatineni wrote:
> As per Sony IMX274 Y_OUT_SIZE should be the height of effective
> image output from the sensor which are the actual total lines
> sent over MIPI CSI to receiver.
>
> So, Y_OUT_SIZE should be same as crop height and this patch fixes it.
>
> Signed-off-by: Sowjanya Komatineni <[email protected]>
> ---
> drivers/media/i2c/imx274.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Thierry Reding <[email protected]>


Attachments:
(No filename) (528.00 B)
signature.asc (849.00 B)
Download all attachments