2020-09-22 10:17:34

by Piyush Mehta

Subject: [PATCH V2 1/2] dt-bindings: ata: ahci: ceva: Update documentation for CEVA Controller

This patch updates the documentation for the CEVA controller for adding
the optional properties for 'phys' and 'resets'.

Signed-off-by: Piyush Mehta <[email protected]>
---
Documentation/devicetree/bindings/ata/ahci-ceva.txt | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
index 7561cc4..da423eb 100644
--- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
+++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
@@ -38,6 +38,9 @@ Required properties:

Optional properties:
- ceva,broken-gen2: limit to gen1 speed instead of gen2.
+ - phys: phandle for the PHY device
+ - phy-names: Should be "sata-phy"
+ - resets: phandle to the reset controller for the SATA IP

Examples:
ahci@fd0c0000 {
@@ -56,4 +59,7 @@ Examples:
ceva,p1-burst-params = /bits/ 8 <0x0A 0x08 0x4A 0x06>;
ceva,p1-retry-params = /bits/ 16 <0x0216 0x7F06>;
ceva,broken-gen2;
+ phy-names = "sata-phy";
+ phys = <&psgtr 1 PHY_TYPE_SATA 1 1>;
+ resets = <&zynqmp_reset ZYNQMP_RESET_SATA>;
};
--
2.7.4

2020-09-29 18:11:46

by Rob Herring (Arm)

Subject: Re: [PATCH V2 1/2] dt-bindings: ata: ahci: ceva: Update documentation for CEVA Controller

On Tue, Sep 22, 2020 at 03:45:12PM +0530, Piyush Mehta wrote:
> This patch updates the documentation for the CEVA controller for adding
> the optional properties for 'phys' and 'resets'.
>
> Signed-off-by: Piyush Mehta <[email protected]>
> ---
> Documentation/devicetree/bindings/ata/ahci-ceva.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> index 7561cc4..da423eb 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> @@ -38,6 +38,9 @@ Required properties:
>
> Optional properties:
> - ceva,broken-gen2: limit to gen1 speed instead of gen2.
> + - phys: phandle for the PHY device
> + - phy-names: Should be "sata-phy"

Not really a useful name. There's not much point to *-names when only 1.

> + - resets: phandle to the reset controller for the SATA IP
>
> Examples:
> ahci@fd0c0000 {
> @@ -56,4 +59,7 @@ Examples:
> ceva,p1-burst-params = /bits/ 8 <0x0A 0x08 0x4A 0x06>;
> ceva,p1-retry-params = /bits/ 16 <0x0216 0x7F06>;
> ceva,broken-gen2;
> + phy-names = "sata-phy";
> + phys = <&psgtr 1 PHY_TYPE_SATA 1 1>;
> + resets = <&zynqmp_reset ZYNQMP_RESET_SATA>;
> };
> --
> 2.7.4
>