2020-09-14 05:44:35

by Chunfeng Yun

[permalink] [raw]
Subject: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root

Fix up the build error caused by undeclared usb_debug_root

Cc: stable <[email protected]>
Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Chunfeng Yun <[email protected]>
---
drivers/usb/gadget/udc/bcm63xx_udc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc/bcm63xx_udc.c
index feaec00..9cd4a70 100644
--- a/drivers/usb/gadget/udc/bcm63xx_udc.c
+++ b/drivers/usb/gadget/udc/bcm63xx_udc.c
@@ -26,6 +26,7 @@
#include <linux/seq_file.h>
#include <linux/slab.h>
#include <linux/timer.h>
+#include <linux/usb.h>
#include <linux/usb/ch9.h>
#include <linux/usb/gadget.h>
#include <linux/workqueue.h>
--
1.9.1


2020-09-14 06:15:25

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root

On Mon, Sep 14, 2020 at 01:38:50PM +0800, Chunfeng Yun wrote:
> Fix up the build error caused by undeclared usb_debug_root
>
> Cc: stable <[email protected]>
> Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")

Nit, you need a ' ' before the '(' character...

thanks,

greg k-h

2020-09-14 06:20:03

by Chunfeng Yun

[permalink] [raw]
Subject: Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root

On Mon, 2020-09-14 at 08:12 +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 14, 2020 at 01:38:50PM +0800, Chunfeng Yun wrote:
> > Fix up the build error caused by undeclared usb_debug_root
> >
> > Cc: stable <[email protected]>
> > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
>
> Nit, you need a ' ' before the '(' character...
Ok, thanks
>
> thanks,
>
> greg k-h

2020-09-24 07:52:05

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root

Chunfeng Yun <[email protected]> writes:

> Fix up the build error caused by undeclared usb_debug_root
>
> Cc: stable <[email protected]>
> Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Chunfeng Yun <[email protected]>

$ patch -p1 --dry-run p.patch
/usr/bin/patch: **** Only garbage was found in the patch input.

--
balbi


Attachments:
signature.asc (873.00 B)

2020-09-24 08:33:11

by Chunfeng Yun

[permalink] [raw]
Subject: Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root

On Thu, 2020-09-24 at 10:50 +0300, Felipe Balbi wrote:
> Chunfeng Yun <[email protected]> writes:
>
> > Fix up the build error caused by undeclared usb_debug_root
> >
> > Cc: stable <[email protected]>
> > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Chunfeng Yun <[email protected]>
>
> $ patch -p1 --dry-run p.patch
> /usr/bin/patch: **** Only garbage was found in the patch input.
>
Please try to apply v2, https://patchwork.kernel.org/patch/11772911/
I indeed add a line code


2020-09-24 08:54:36

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH] usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root


Hi,

Chunfeng Yun <[email protected]> writes:
> On Thu, 2020-09-24 at 10:50 +0300, Felipe Balbi wrote:
>> Chunfeng Yun <[email protected]> writes:
>>
>> > Fix up the build error caused by undeclared usb_debug_root
>> >
>> > Cc: stable <[email protected]>
>> > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root")
>> > Reported-by: kernel test robot <[email protected]>
>> > Signed-off-by: Chunfeng Yun <[email protected]>
>>
>> $ patch -p1 --dry-run p.patch
>> /usr/bin/patch: **** Only garbage was found in the patch input.
>>
> Please try to apply v2, https://patchwork.kernel.org/patch/11772911/
> I indeed add a line code

that worked, but the problem I have is that your patches always come
base64 encoded. Make sure they come as plain text in the future :-)

--
balbi


Attachments:
signature.asc (873.00 B)