2020-09-24 14:37:46

by Li Heng

Subject: [PATCH -next] xen: Fix a previous prototype warning in xen.c

Fix the warning:
arch/x86/pci/xen.c:423:13: warning:
no previous prototype for ‘xen_msi_init’ [-Wmissing-prototypes]

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Li Heng <[email protected]>
---
arch/x86/pci/xen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
index 89395a5..f663a5f 100644
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -420,7 +420,7 @@ int __init pci_xen_init(void)
}

#ifdef CONFIG_PCI_MSI
-void __init xen_msi_init(void)
+static void __init xen_msi_init(void)
{
if (!disable_apic) {
/*
--
2.7.4

2020-09-28 23:19:20

by Bjorn Helgaas

Subject: Re: [PATCH -next] xen: Fix a previous prototype warning in xen.c

On Thu, Sep 24, 2020 at 10:36:16PM +0800, Li Heng wrote:
> Fix the warning:
> arch/x86/pci/xen.c:423:13: warning:
> no previous prototype for ‘xen_msi_init’ [-Wmissing-prototypes]
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Li Heng <[email protected]>

Applied to pci/misc for v5.10, thanks!

> ---
> arch/x86/pci/xen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> index 89395a5..f663a5f 100644
> --- a/arch/x86/pci/xen.c
> +++ b/arch/x86/pci/xen.c
> @@ -420,7 +420,7 @@ int __init pci_xen_init(void)
> }
>
> #ifdef CONFIG_PCI_MSI
> -void __init xen_msi_init(void)
> +static void __init xen_msi_init(void)
> {
> if (!disable_apic) {
> /*
> --
> 2.7.4
>