2020-09-30 03:01:21

by Sowjanya Komatineni

[permalink] [raw]
Subject: [PATCH v1 0/2] Allow building Tegra video driver with COMPILE_TEST

This series enables COMPILE_TEST for Tegra video driver.

Tegra video driver has dependency on host1x driver. So this series also
includes a patch to allow building host1x driver with COMPILE_TEST for
all platforms.

Sowjanya Komatineni (2):
gpu: host1x: Allow COMPILE_TEST to build host1x driver on all
platforms
media: tegra-video: Allow building driver with COMPILE_TEST

drivers/gpu/host1x/Kconfig | 2 +-
drivers/staging/media/tegra-video/Kconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

--
2.7.4


2020-09-30 03:01:24

by Sowjanya Komatineni

[permalink] [raw]
Subject: [PATCH v1 2/2] media: tegra-video: Allow building driver with COMPILE_TEST

This patch adds COMPILE_TEST option to Kconfig to allow building
it with COMPILE_TEST option.

Signed-off-by: Sowjanya Komatineni <[email protected]>
---
drivers/staging/media/tegra-video/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/tegra-video/Kconfig b/drivers/staging/media/tegra-video/Kconfig
index 1f35da4..3e03ddd 100644
--- a/drivers/staging/media/tegra-video/Kconfig
+++ b/drivers/staging/media/tegra-video/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config VIDEO_TEGRA
tristate "NVIDIA Tegra VI driver"
- depends on TEGRA_HOST1X
+ depends on TEGRA_HOST1X || COMPILE_TEST
depends on VIDEO_V4L2
select MEDIA_CONTROLLER
select VIDEOBUF2_DMA_CONTIG
--
2.7.4

2020-09-30 03:01:30

by Sowjanya Komatineni

[permalink] [raw]
Subject: [PATCH v1 1/2] gpu: host1x: Allow COMPILE_TEST to build host1x driver on all platforms

Tegra V4L2 driver has dependency on this host1x driver and currently
host1x driver is allowed to build with COMPILE_TEST only on ARM and
this also limits Tegra V4L2 driver building.

So, this patch allows building host1x driver with COMPILE_TEST on
all platforms.

Signed-off-by: Sowjanya Komatineni <[email protected]>
---
drivers/gpu/host1x/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
index 6dab94a..977a0ac 100644
--- a/drivers/gpu/host1x/Kconfig
+++ b/drivers/gpu/host1x/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config TEGRA_HOST1X
tristate "NVIDIA Tegra host1x driver"
- depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+ depends on ARCH_TEGRA || COMPILE_TEST
select IOMMU_IOVA
help
Driver for the NVIDIA Tegra host1x hardware.
--
2.7.4

2020-09-30 17:38:21

by Michał Mirosław

[permalink] [raw]
Subject: Re: [PATCH v1 2/2] media: tegra-video: Allow building driver with COMPILE_TEST

On Tue, Sep 29, 2020 at 08:02:38PM -0700, Sowjanya Komatineni wrote:
> This patch adds COMPILE_TEST option to Kconfig to allow building
> it with COMPILE_TEST option.

Does it build without TEGRA_HOST1X selected? Isn't the previous patch
enough to allow the build with COMPILE_TEST?

Best Regards,
Micha? Miros?aw

2020-09-30 17:58:37

by Sowjanya Komatineni

[permalink] [raw]
Subject: Re: [PATCH v1 2/2] media: tegra-video: Allow building driver with COMPILE_TEST


On 9/30/20 10:34 AM, Micha? Miros?aw wrote:
> On Tue, Sep 29, 2020 at 08:02:38PM -0700, Sowjanya Komatineni wrote:
>> This patch adds COMPILE_TEST option to Kconfig to allow building
>> it with COMPILE_TEST option.
> Does it build without TEGRA_HOST1X selected? Isn't the previous patch
> enough to allow the build with COMPILE_TEST?
>
> Best Regards,
> Micha? Miros?aw

No, it does not build without selecting CONFIG_TEGRA_HOST1X along with
CONFIG_VIDEO_TEGRA

2020-10-30 11:05:03

by Hans Verkuil

[permalink] [raw]
Subject: Re: [PATCH v1 1/2] gpu: host1x: Allow COMPILE_TEST to build host1x driver on all platforms

Thierry,

On 30/09/2020 05:02, Sowjanya Komatineni wrote:
> Tegra V4L2 driver has dependency on this host1x driver and currently
> host1x driver is allowed to build with COMPILE_TEST only on ARM and
> this also limits Tegra V4L2 driver building.
>
> So, this patch allows building host1x driver with COMPILE_TEST on
> all platforms.

Can you Ack/Review this so I can merge both patches for v5.11?
If you prefer to merge this on your side, then I can Ack patch 2/2
as well, but I think it makes more sense if this goes through the
media subsystem.

Regards,

Hans

>
> Signed-off-by: Sowjanya Komatineni <[email protected]>
> ---
> drivers/gpu/host1x/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> index 6dab94a..977a0ac 100644
> --- a/drivers/gpu/host1x/Kconfig
> +++ b/drivers/gpu/host1x/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config TEGRA_HOST1X
> tristate "NVIDIA Tegra host1x driver"
> - depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> + depends on ARCH_TEGRA || COMPILE_TEST
> select IOMMU_IOVA
> help
> Driver for the NVIDIA Tegra host1x hardware.
>