2020-10-02 08:31:15

by Chen, Rong A

[permalink] [raw]
Subject: [drm/i915/gt] 98479ada42: phoronix-test-suite.supertuxkart.1024x768.Windowed.Basic.1.OldMine.frames_per_second -36.0% regression

Greeting,

FYI, we noticed a -36.0% regression of phoronix-test-suite.supertuxkart.1024x768.Windowed.Basic.1.OldMine.frames_per_second due to commit:


commit: 98479ada421a8fd2123b98efd398a6f1379307ab ("drm/i915/gt: Treat idling as a RPS downclock event")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master


in testcase: phoronix-test-suite
on test machine: 4 threads Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz with 32G memory
with following parameters:

need_x: true
test: supertuxkart-1.5.2
option_a: Windowed
option_b: Basic
option_c: 1
option_d: Old Mine [Approximately 90k triangles]
cpufreq_governor: performance
ucode: 0xd6

test-description: The Phoronix Test Suite is the most comprehensive testing and benchmarking platform available that provides an extensible framework for which new tests can be easily added.
test-url: http://www.phoronix-test-suite.com/

In addition to that, the commit also has significant impact on the following tests:

+------------------+---------------------------------------------------------------------------------------------------------------------------------------+
| testcase: change | phoronix-test-suite: phoronix-test-suite.supertuxkart.1024x768.Windowed.Basic.1.CocoaTemple.frames_per_second -13.3% regression |
| test machine | 4 threads Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz with 32G memory |
| test parameters | cpufreq_governor=performance |
| | need_x=true |
| | option_a=Windowed |
| | option_b=Basic |
| | option_c=1 |
| | option_d=Cocoa Temple [Approximately 300k triangles; advanced graphics] |
| | test=supertuxkart-1.5.2 |
| | ucode=0xd6 |
+------------------+---------------------------------------------------------------------------------------------------------------------------------------+
| testcase: change | phoronix-test-suite: phoronix-test-suite.paraview.WaveletVolume.1024x768.mivoxels___sec -51.1% regression |
| test machine | 4 threads Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz with 32G memory |
| test parameters | cpufreq_governor=performance |
| | need_x=true |
| | option_a=Wavelet Volume |
| | test=paraview-1.0.2 |
| | ucode=0xd6 |
+------------------+---------------------------------------------------------------------------------------------------------------------------------------+
| testcase: change | phoronix-test-suite: phoronix-test-suite.supertuxkart.1024x768.Windowed.Basic.8.AntediluvianAbyss.frames_per_second -48.8% regression |
| test machine | 4 threads Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz with 32G memory |
| test parameters | cpufreq_governor=performance |
| | need_x=true |
| | option_a=Windowed |
| | option_b=Basic |
| | option_c=8 |
| | option_d=Antediluvian Abyss [Approximately 240k triangles; advanced graphics] |
| | test=supertuxkart-1.5.2 |
| | ucode=0xd6 |
+------------------+---------------------------------------------------------------------------------------------------------------------------------------+


If you fix the issue, kindly add following tag
Reported-by: kernel test robot <[email protected]>


Details are as below:
-------------------------------------------------------------------------------------------------->


To reproduce:

git clone https://github.com/intel/lkp-tests.git
cd lkp-tests
bin/lkp install job.yaml # job file is attached in this email
bin/lkp run job.yaml

=========================================================================================
compiler/cpufreq_governor/kconfig/need_x/option_a/option_b/option_c/option_d/rootfs/tbox_group/test/testcase/ucode:
gcc-9/performance/x86_64-rhel-8.3/true/Windowed/Basic/1/Old Mine [Approximately 90k triangles]/debian-x86_64-phoronix/lkp-kbl-nuc1/supertuxkart-1.5.2/phoronix-test-suite/0xd6

commit:
a24c57d0b3 ("drm/i915/gt: Cancel a hung context if already closed")
98479ada42 ("drm/i915/gt: Treat idling as a RPS downclock event")

a24c57d0b3ed9be0 98479ada421a8fd2123b98efd39
---------------- ---------------------------
%stddev %change %stddev
\ | \
650.98 -36.0% 416.63 phoronix-test-suite.supertuxkart.1024x768.Windowed.Basic.1.OldMine.frames_per_second
239.42 +38.0% 330.29 ± 18% phoronix-test-suite.time.elapsed_time
239.42 +38.0% 330.29 ± 18% phoronix-test-suite.time.elapsed_time.max
2512 ± 85% +505.3% 15205 ± 94% phoronix-test-suite.time.involuntary_context_switches
215317 +21.2% 260934 ± 11% phoronix-test-suite.time.minor_page_faults
84.00 -39.9% 50.50 phoronix-test-suite.time.percent_of_cpu_this_job_got
26.33 -22.5% 20.41 ± 19% phoronix-test-suite.time.system_time
175.94 -15.9% 148.02 ± 18% phoronix-test-suite.time.user_time
189640 +104.4% 387650 ± 18% phoronix-test-suite.time.voluntary_context_switches





700 +---------------------------------------------------------------------+
| |
650 |.+.+ .+.+.+.++.+.+.+.++.+.+.+.++.+.+.++.+.+.+.++.+.+.+.++.+.+.+.++.+.|
| + + |
| |
600 |-+ |
| |
550 |-+ |
| |
500 |-+ |
| |
| |
450 |-+ |
| O OO O O O OO O O O OO O O O OO |
400 +---------------------------------------------------------------------+


phoronix-test-suite.time.percent_of_cpu_this_job_got

85 +----------------------------------------------------------------------+
| + + .+.+ +.+.+ + + + + + |
80 |-+ + |
75 |-+ |
| |
70 |-+ |
| |
65 |-+ |
| |
60 |-+ |
55 |-+ |
| |
50 |-O OO O O O OO O O O OO O O O O |
| O |
45 +----------------------------------------------------------------------+


[*] bisect-good sample
[O] bisect-bad sample

***************************************************************************************************
lkp-kbl-nuc1: 4 threads Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz with 32G memory
=========================================================================================
compiler/cpufreq_governor/kconfig/need_x/option_a/option_b/option_c/option_d/rootfs/tbox_group/test/testcase/ucode:
gcc-9/performance/x86_64-rhel-8.3/true/Windowed/Basic/1/Cocoa Temple [Approximately 300k triangles; advanced graphics]/debian-x86_64-phoronix/lkp-kbl-nuc1/supertuxkart-1.5.2/phoronix-test-suite/0xd6

commit:
a24c57d0b3 ("drm/i915/gt: Cancel a hung context if already closed")
98479ada42 ("drm/i915/gt: Treat idling as a RPS downclock event")

a24c57d0b3ed9be0 98479ada421a8fd2123b98efd39
---------------- ---------------------------
%stddev %change %stddev
\ | \
256.74 -13.3% 222.46 phoronix-test-suite.supertuxkart.1024x768.Windowed.Basic.1.CocoaTemple.frames_per_second
84.50 -12.1% 74.25 phoronix-test-suite.time.percent_of_cpu_this_job_got



***************************************************************************************************
lkp-kbl-nuc1: 4 threads Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz with 32G memory
=========================================================================================
compiler/cpufreq_governor/kconfig/need_x/option_a/rootfs/tbox_group/test/testcase/ucode:
gcc-9/performance/x86_64-rhel-8.3/true/Wavelet Volume/debian-x86_64-phoronix/lkp-kbl-nuc1/paraview-1.0.2/phoronix-test-suite/0xd6

commit:
a24c57d0b3 ("drm/i915/gt: Cancel a hung context if already closed")
98479ada42 ("drm/i915/gt: Treat idling as a RPS downclock event")

a24c57d0b3ed9be0 98479ada421a8fd2123b98efd39
---------------- ---------------------------
%stddev %change %stddev
\ | \
44.28 ± 24% -51.1% 21.64 ± 6% phoronix-test-suite.paraview.WaveletVolume.1024x768.frames___sec
708.54 ± 24% -51.1% 346.21 ± 6% phoronix-test-suite.paraview.WaveletVolume.1024x768.mivoxels___sec
284183 +122.9% 633483 ± 46% phoronix-test-suite.time.minor_page_faults



***************************************************************************************************
lkp-kbl-nuc1: 4 threads Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz with 32G memory
=========================================================================================
compiler/cpufreq_governor/kconfig/need_x/option_a/option_b/option_c/option_d/rootfs/tbox_group/test/testcase/ucode:
gcc-9/performance/x86_64-rhel-8.3/true/Windowed/Basic/8/Antediluvian Abyss [Approximately 240k triangles; advanced graphics]/debian-x86_64-phoronix/lkp-kbl-nuc1/supertuxkart-1.5.2/phoronix-test-suite/0xd6

commit:
a24c57d0b3 ("drm/i915/gt: Cancel a hung context if already closed")
98479ada42 ("drm/i915/gt: Treat idling as a RPS downclock event")

a24c57d0b3ed9be0 98479ada421a8fd2123b98efd39
---------------- ---------------------------
%stddev %change %stddev
\ | \
428.34 -48.8% 219.30 ± 4% phoronix-test-suite.supertuxkart.1024x768.Windowed.Basic.8.AntediluvianAbyss.frames_per_second
1494 ± 60% +1913.0% 30074 ± 43% phoronix-test-suite.time.involuntary_context_switches
84.00 ± 2% -55.4% 37.50 ± 4% phoronix-test-suite.time.percent_of_cpu_this_job_got
395421 ± 86% +168.5% 1061674 ± 42% phoronix-test-suite.time.voluntary_context_switches





Disclaimer:
Results have been estimated based on internal Intel analysis and are provided
for informational purposes only. Any difference in system hardware or software
design or configuration may affect actual performance.


Thanks,
Rong Chen


Attachments:
(No filename) (14.91 kB)
config-5.6.0-rc5-01490-g98479ada421a8 (157.49 kB)
job-script (7.54 kB)
job.yaml (5.15 kB)
reproduce (314.00 B)
Download all attachments

2020-10-02 08:47:10

by Chris Wilson

[permalink] [raw]
Subject: Re: [drm/i915/gt] 98479ada42: phoronix-test-suite.supertuxkart.1024x768.Windowed.Basic.1.OldMine.frames_per_second -36.0% regression

Quoting kernel test robot (2020-10-02 09:27:40)
> Greeting,
>
> FYI, we noticed a -36.0% regression of phoronix-test-suite.supertuxkart.1024x768.Windowed.Basic.1.OldMine.frames_per_second due to commit:

Where's the power consumption graph? You have a benchmark that although
is running faster than the display is failing to keep the GPU busy. That
alone says there is a latency issue along the GL paths. Is papering over
an issue in command submission worth the power cost?
-Chris