2020-10-29 07:45:29

by Zou Wei

Subject: [PATCH -next] mm, page_alloc: Fix old-style function definition

Fix warning:

mm/page_alloc.c:763:6: warning: old-style function definition [-Wold-style-definition]
void init_mem_debugging()
^~~~~~~~~~~~~~~~~~

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index f80dc59..470b18d 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -760,7 +760,7 @@ static inline void clear_page_guard(struct zone *zone, struct page *page,
* order of appearance. So we need to first gather the full picture of what was
* enabled, and then make decisions.
*/
-void init_mem_debugging()
+void init_mem_debugging(void)
{
if (_init_on_alloc_enabled_early) {
if (page_poisoning_enabled()) {
--
2.6.2

2020-10-30 11:41:16

by David Hildenbrand

Subject: Re: [PATCH -next] mm, page_alloc: Fix old-style function definition

On 28.10.20 08:32, Zou Wei wrote:
> Fix warning:
>
> mm/page_alloc.c:763:6: warning: old-style function definition [-Wold-style-definition]
> void init_mem_debugging()
> ^~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index f80dc59..470b18d 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -760,7 +760,7 @@ static inline void clear_page_guard(struct zone *zone, struct page *page,
> * order of appearance. So we need to first gather the full picture of what was
> * enabled, and then make decisions.
> */
> -void init_mem_debugging()
> +void init_mem_debugging(void)
> {
> if (_init_on_alloc_enabled_early) {
> if (page_poisoning_enabled()) {
>

Acked-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb