2020-10-29 08:56:25

by Zou Wei

Subject: [PATCH -next] coresight: core: Remove unneeded semicolon

Fixes coccicheck warning:

./drivers/hwtracing/coresight/coresight-core.c:421:4-5: Unneeded semicolon

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/hwtracing/coresight/coresight-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
index cc9e802..29c83ea 100644
--- a/drivers/hwtracing/coresight/coresight-core.c
+++ b/drivers/hwtracing/coresight/coresight-core.c
@@ -418,7 +418,7 @@ static int coresight_enable_source(struct coresight_device *csdev, u32 mode)
if (ret) {
coresight_control_assoc_ectdev(csdev, false);
return ret;
- };
+ }
}
csdev->enable = true;
}
--
2.6.2

2020-10-29 17:38:02

by Mathieu Poirier

Subject: Re: [PATCH -next] coresight: core: Remove unneeded semicolon

Hi Wei,

On Thu, Oct 29, 2020 at 10:25:48AM +0800, Zou Wei wrote:
> Fixes coccicheck warning:
>
> ./drivers/hwtracing/coresight/coresight-core.c:421:4-5: Unneeded semicolon
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/hwtracing/coresight/coresight-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index cc9e802..29c83ea 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -418,7 +418,7 @@ static int coresight_enable_source(struct coresight_device *csdev, u32 mode)
> if (ret) {
> coresight_control_assoc_ectdev(csdev, false);
> return ret;
> - };
> + }

I picked up your patch.

Thanks,
Mathieu

> }
> csdev->enable = true;
> }
> --
> 2.6.2
>