2020-10-30 03:02:21

by Yi Sun

Subject: [PATCH v2 2/2] iommu/vt-d: Fix a bug for PDP check in prq_event_thread

From: "Liu, Yi L" <[email protected]>

In prq_event_thread(), the QI_PGRP_PDP is wrongly set by
'req->pasid_present' which should be replaced to
'req->priv_data_present'.

Fixes: 5b438f4ba315 ("iommu/vt-d: Support page request in scalable mode")
Signed-off-by: Liu, Yi L <[email protected]>
Signed-off-by: Yi Sun <[email protected]>
---
drivers/iommu/intel/svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
index 7584669..3242ebd 100644
--- a/drivers/iommu/intel/svm.c
+++ b/drivers/iommu/intel/svm.c
@@ -1035,7 +1035,7 @@ static irqreturn_t prq_event_thread(int irq, void *d)
resp.qw0 = QI_PGRP_PASID(req->pasid) |
QI_PGRP_DID(req->rid) |
QI_PGRP_PASID_P(req->pasid_present) |
- QI_PGRP_PDP(req->pasid_present) |
+ QI_PGRP_PDP(req->priv_data_present) |
QI_PGRP_RESP_CODE(result) |
QI_PGRP_RESP_TYPE;
resp.qw1 = QI_PGRP_IDX(req->prg_index) |
--
2.7.4

2020-10-30 13:00:28

by Lu Baolu

Subject: Re: [PATCH v2 2/2] iommu/vt-d: Fix a bug for PDP check in prq_event_thread

On 10/30/20 10:37 AM, Yi Sun wrote:
> From: "Liu, Yi L" <[email protected]>
>
> In prq_event_thread(), the QI_PGRP_PDP is wrongly set by
> 'req->pasid_present' which should be replaced to
> 'req->priv_data_present'.
>
> Fixes: 5b438f4ba315 ("iommu/vt-d: Support page request in scalable mode")
> Signed-off-by: Liu, Yi L <[email protected]>
> Signed-off-by: Yi Sun <[email protected]>

Cc: [email protected]
Acked-by: Lu Baolu <[email protected]>

Best regards,
baolu

> ---
> drivers/iommu/intel/svm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
> index 7584669..3242ebd 100644
> --- a/drivers/iommu/intel/svm.c
> +++ b/drivers/iommu/intel/svm.c
> @@ -1035,7 +1035,7 @@ static irqreturn_t prq_event_thread(int irq, void *d)
> resp.qw0 = QI_PGRP_PASID(req->pasid) |
> QI_PGRP_DID(req->rid) |
> QI_PGRP_PASID_P(req->pasid_present) |
> - QI_PGRP_PDP(req->pasid_present) |
> + QI_PGRP_PDP(req->priv_data_present) |
> QI_PGRP_RESP_CODE(result) |
> QI_PGRP_RESP_TYPE;
> resp.qw1 = QI_PGRP_IDX(req->prg_index) |
>