2020-11-03 04:00:47

by Yejune Deng

[permalink] [raw]

Subject: [PATCH] usb: dwc3: core: Replace devm_reset_control_array_get()

---

devm_reset_control_array_get_optional_shared() looks more readable

Signed-off-by: Yejune Deng <[email protected]>
---
drivers/usb/dwc3/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 841daec..b87acf0 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1490,7 +1490,7 @@ static int dwc3_probe(struct platform_device *pdev)

dwc3_get_properties(dwc);

- dwc->reset = devm_reset_control_array_get(dev, true, true);
+ dwc->reset = devm_reset_control_array_get_optional_shared(dev);
if (IS_ERR(dwc->reset))
return PTR_ERR(dwc->reset);

--
1.9.1

2021-01-07 19:19:21

by Dmitry Osipenko

[permalink] [raw]

Subject: Re: [PATCH] usb: dwc3: core: Replace devm_reset_control_array_get()

---

03.11.2020 06:57, Yejune Deng пишет:
> devm_reset_control_array_get_optional_shared() looks more readable
>
> Signed-off-by: Yejune Deng <[email protected]>
> ---
> drivers/usb/dwc3/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 841daec..b87acf0 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1490,7 +1490,7 @@ static int dwc3_probe(struct platform_device *pdev)
>
> dwc3_get_properties(dwc);
>
> - dwc->reset = devm_reset_control_array_get(dev, true, true);
> + dwc->reset = devm_reset_control_array_get_optional_shared(dev);
> if (IS_ERR(dwc->reset))
> return PTR_ERR(dwc->reset);
>
>

Greg / Felipe, could you please pick up this patch?

I want to add devm_reset_control_array_get_exclusive_released() for
NVIDIA Tegra drivers and we need to get rid of all the open-coded
devm_reset_control_array_get() users in order to extend the reset API
sanely.

Thanks in advance.

2021-01-07 19:24:49

by Greg Kroah-Hartman

[permalink] [raw]

Subject: Re: [PATCH] usb: dwc3: core: Replace devm_reset_control_array_get()

---

On Thu, Jan 07, 2021 at 10:16:50PM +0300, Dmitry Osipenko wrote:
> 03.11.2020 06:57, Yejune Deng пишет:
> > devm_reset_control_array_get_optional_shared() looks more readable
> >
> > Signed-off-by: Yejune Deng <[email protected]>
> > ---
> > drivers/usb/dwc3/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> > index 841daec..b87acf0 100644
> > --- a/drivers/usb/dwc3/core.c
> > +++ b/drivers/usb/dwc3/core.c
> > @@ -1490,7 +1490,7 @@ static int dwc3_probe(struct platform_device *pdev)
> >
> > dwc3_get_properties(dwc);
> >
> > - dwc->reset = devm_reset_control_array_get(dev, true, true);
> > + dwc->reset = devm_reset_control_array_get_optional_shared(dev);
> > if (IS_ERR(dwc->reset))
> > return PTR_ERR(dwc->reset);
> >
> >
>
> Greg / Felipe, could you please pick up this patch?
>
> I want to add devm_reset_control_array_get_exclusive_released() for
> NVIDIA Tegra drivers and we need to get rid of all the open-coded
> devm_reset_control_array_get() users in order to extend the reset API
> sanely.

Care to ack it or send a reviewed-by for it?

thanks,

greg k-h

2021-01-07 19:36:04

by Dmitry Osipenko

[permalink] [raw]

Subject: Re: [PATCH] usb: dwc3: core: Replace devm_reset_control_array_get()

---

03.11.2020 06:57, Yejune Deng пишет:
> devm_reset_control_array_get_optional_shared() looks more readable
>
> Signed-off-by: Yejune Deng <[email protected]>
> ---
> drivers/usb/dwc3/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 841daec..b87acf0 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1490,7 +1490,7 @@ static int dwc3_probe(struct platform_device *pdev)
>
> dwc3_get_properties(dwc);
>
> - dwc->reset = devm_reset_control_array_get(dev, true, true);
> + dwc->reset = devm_reset_control_array_get_optional_shared(dev);
> if (IS_ERR(dwc->reset))
> return PTR_ERR(dwc->reset);
>
>

Reviewed-by: Dmitry Osipenko <[email protected]>

2021-01-07 20:47:11

by Dmitry Osipenko

[permalink] [raw]

Subject: Re: [PATCH] usb: dwc3: core: Replace devm_reset_control_array_get()

---

07.01.2021 22:23, Greg KH пишет:
> On Thu, Jan 07, 2021 at 10:16:50PM +0300, Dmitry Osipenko wrote:
>> 03.11.2020 06:57, Yejune Deng пишет:
>>> devm_reset_control_array_get_optional_shared() looks more readable
>>>
>>> Signed-off-by: Yejune Deng <[email protected]>
>>> ---
>>> drivers/usb/dwc3/core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>>> index 841daec..b87acf0 100644
>>> --- a/drivers/usb/dwc3/core.c
>>> +++ b/drivers/usb/dwc3/core.c
>>> @@ -1490,7 +1490,7 @@ static int dwc3_probe(struct platform_device *pdev)
>>>
>>> dwc3_get_properties(dwc);
>>>
>>> - dwc->reset = devm_reset_control_array_get(dev, true, true);
>>> + dwc->reset = devm_reset_control_array_get_optional_shared(dev);
>>> if (IS_ERR(dwc->reset))
>>> return PTR_ERR(dwc->reset);
>>>
>>>
>>
>> Greg / Felipe, could you please pick up this patch?
>>
>> I want to add devm_reset_control_array_get_exclusive_released() for
>> NVIDIA Tegra drivers and we need to get rid of all the open-coded
>> devm_reset_control_array_get() users in order to extend the reset API
>> sanely.
>
> Care to ack it or send a reviewed-by for it?

I sent r-b, thanks.

2021-01-08 12:32:26

by Felipe Balbi

[permalink] [raw]

Subject: Re: [PATCH] usb: dwc3: core: Replace devm_reset_control_array_get()

---

Yejune Deng <[email protected]> writes:

> devm_reset_control_array_get_optional_shared() looks more readable
>
> Signed-off-by: Yejune Deng <[email protected]>

Acked-by: Felipe Balbi <[email protected]>

--
balbi

---

Attachments:

signature.asc (873.00 B)