2020-11-03 11:23:13

by Zou Wei

Subject: [PATCH -next] clk: imx: gate2: Remove unused variable ret

This patch fixes below warning reported by coccicheck:

./clk-gate2.c:57:5-8: Unneeded variable: "ret". Return "0" on line 68

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/clk/imx/clk-gate2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/imx/clk-gate2.c b/drivers/clk/imx/clk-gate2.c
index 480a184..f16c401 100644
--- a/drivers/clk/imx/clk-gate2.c
+++ b/drivers/clk/imx/clk-gate2.c
@@ -54,7 +54,6 @@ static int clk_gate2_enable(struct clk_hw *hw)
{
struct clk_gate2 *gate = to_clk_gate2(hw);
unsigned long flags;
- int ret = 0;

spin_lock_irqsave(gate->lock, flags);

@@ -65,7 +64,7 @@ static int clk_gate2_enable(struct clk_hw *hw)
out:
spin_unlock_irqrestore(gate->lock, flags);

- return ret;
+ return 0;
}

static void clk_gate2_disable(struct clk_hw *hw)
--
2.6.2

2020-11-05 04:36:09

by Stephen Boyd

Subject: Re: [PATCH -next] clk: imx: gate2: Remove unused variable ret

Quoting Zou Wei (2020-11-03 03:32:14)
> This patch fixes below warning reported by coccicheck:
>
> ./clk-gate2.c:57:5-8: Unneeded variable: "ret". Return "0" on line 68
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2020-11-10 01:11:11

by Shawn Guo

Subject: Re: [PATCH -next] clk: imx: gate2: Remove unused variable ret

On Tue, Nov 03, 2020 at 07:32:14PM +0800, Zou Wei wrote:
> This patch fixes below warning reported by coccicheck:
>
> ./clk-gate2.c:57:5-8: Unneeded variable: "ret". Return "0" on line 68
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Applied, thanks.