2020-11-04 11:10:10

by Zou Wei

Subject: [PATCH -next] clk: imx: scu: Make pd_np with static keyword

Fix the following sparse warning:

./clk-scu.c:23:20: warning: symbol 'pd_np' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/clk/imx/clk-scu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
index d0243c5..d10f60e 100644
--- a/drivers/clk/imx/clk-scu.c
+++ b/drivers/clk/imx/clk-scu.c
@@ -20,7 +20,7 @@
#define IMX_SIP_SET_CPUFREQ 0x00

static struct imx_sc_ipc *ccm_ipc_handle;
-struct device_node *pd_np;
+static struct device_node *pd_np;
static struct platform_driver imx_clk_scu_driver;

struct imx_scu_clk_node {
--
2.6.2

2020-11-05 06:34:33

by Stephen Boyd

Subject: Re: [PATCH -next] clk: imx: scu: Make pd_np with static keyword

Quoting Zou Wei (2020-11-04 03:19:31)
> Fix the following sparse warning:
>
> ./clk-scu.c:23:20: warning: symbol 'pd_np' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2020-11-10 02:19:26

by Shawn Guo

Subject: Re: [PATCH -next] clk: imx: scu: Make pd_np with static keyword

On Wed, Nov 04, 2020 at 07:19:31PM +0800, Zou Wei wrote:
> Fix the following sparse warning:
>
> ./clk-scu.c:23:20: warning: symbol 'pd_np' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Applied, thanks.