2020-11-06 07:33:18

by Kaixu Xia

Subject: [PATCH] rtc: sc27xx: Remove unnecessary conversion to bool

From: Kaixu Xia <[email protected]>

Here we could use the '!=' expression to fix the following coccicheck
warning:

./drivers/rtc/rtc-sc27xx.c:566:50-55: WARNING: conversion to bool not needed here

Reported-by: Tosk Robot <[email protected]>
Signed-off-by: Kaixu Xia <[email protected]>
---
drivers/rtc/rtc-sc27xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-sc27xx.c b/drivers/rtc/rtc-sc27xx.c
index 36810dd40cd3..6e65f68ea86d 100644
--- a/drivers/rtc/rtc-sc27xx.c
+++ b/drivers/rtc/rtc-sc27xx.c
@@ -563,7 +563,7 @@ static int sprd_rtc_check_power_down(struct sprd_rtc *rtc)
* means the RTC has been powered down, so the RTC time values are
* invalid.
*/
- rtc->valid = val == SPRD_RTC_POWER_RESET_VALUE ? false : true;
+ rtc->valid = val != SPRD_RTC_POWER_RESET_VALUE;
return 0;
}

--
2.20.0

2020-11-14 22:36:34

by Alexandre Belloni

Subject: Re: [PATCH] rtc: sc27xx: Remove unnecessary conversion to bool

On Fri, 6 Nov 2020 15:30:54 +0800, [email protected] wrote:
> Here we could use the '!=' expression to fix the following coccicheck
> warning:
>
> ./drivers/rtc/rtc-sc27xx.c:566:50-55: WARNING: conversion to bool not needed here

Applied, thanks!

[1/1] rtc: sc27xx: Remove unnecessary conversion to bool
commit: 825156a5eeded9bcb55e9c36d4b4b72bf20bcba6

Best regards,
--
Alexandre Belloni <[email protected]>