2020-11-06 08:04:53

by Kaixu Xia

Subject: [PATCH] rtc: da9063: Simplify bool comparison

From: Kaixu Xia <[email protected]>

Fix the following coccicheck warning:

./drivers/rtc/rtc-da9063.c:246:5-18: WARNING: Comparison to bool

Reported-by: Tosk Robot <[email protected]>
Signed-off-by: Kaixu Xia <[email protected]>
---
drivers/rtc/rtc-da9063.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c
index 046b1d4c3dae..6f0a3a711135 100644
--- a/drivers/rtc/rtc-da9063.c
+++ b/drivers/rtc/rtc-da9063.c
@@ -243,7 +243,7 @@ static int da9063_rtc_read_time(struct device *dev, struct rtc_time *tm)
al_secs = rtc_tm_to_time64(&rtc->alarm_time);

/* handle the rtc synchronisation delay */
- if (rtc->rtc_sync == true && al_secs - tm_secs == 1)
+ if (rtc->rtc_sync && al_secs - tm_secs == 1)
memcpy(tm, &rtc->alarm_time, sizeof(struct rtc_time));
else
rtc->rtc_sync = false;
--
2.20.0

2020-11-14 22:37:33

by Alexandre Belloni

Subject: Re: [PATCH] rtc: da9063: Simplify bool comparison

On Fri, 6 Nov 2020 16:00:37 +0800, [email protected] wrote:
> Fix the following coccicheck warning:
>
> ./drivers/rtc/rtc-da9063.c:246:5-18: WARNING: Comparison to bool

Applied, thanks!

[1/1] rtc: da9063: Simplify bool comparison
commit: a48c6224ae07bed02893c58073ca2942acb5c3d5

Best regards,
--
Alexandre Belloni <[email protected]>