2020-11-07 16:17:23

by Kaixu Xia

Subject: [PATCH] ALSA: firewire: fix comparison to bool warning

From: Kaixu Xia <[email protected]>

Fix the following coccicheck warning:

./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool

Reported-by: Tosk Robot <[email protected]>
Signed-off-by: Kaixu Xia <[email protected]>
---
sound/firewire/amdtp-stream.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h
index 2ceb57d1d58e..a3daa1f2c1c4 100644
--- a/sound/firewire/amdtp-stream.h
+++ b/sound/firewire/amdtp-stream.h
@@ -270,7 +270,7 @@ static inline bool amdtp_stream_wait_callback(struct amdtp_stream *s,
unsigned int timeout)
{
return wait_event_timeout(s->callback_wait,
- s->callbacked == true,
+ s->callbacked,
msecs_to_jiffies(timeout)) > 0;
}

--
2.20.0

2020-11-10 08:08:44

by Takashi Iwai

Subject: Re: [PATCH] ALSA: firewire: fix comparison to bool warning

On Sat, 07 Nov 2020 17:13:31 +0100,
[email protected] wrote:
>
> From: Kaixu Xia <[email protected]>
>
> Fix the following coccicheck warning:
>
> ./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool
>
> Reported-by: Tosk Robot <[email protected]>
> Signed-off-by: Kaixu Xia <[email protected]>

Thanks, applied.


Takashi

> ---
> sound/firewire/amdtp-stream.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h
> index 2ceb57d1d58e..a3daa1f2c1c4 100644
> --- a/sound/firewire/amdtp-stream.h
> +++ b/sound/firewire/amdtp-stream.h
> @@ -270,7 +270,7 @@ static inline bool amdtp_stream_wait_callback(struct amdtp_stream *s,
> unsigned int timeout)
> {
> return wait_event_timeout(s->callback_wait,
> - s->callbacked == true,
> + s->callbacked,
> msecs_to_jiffies(timeout)) > 0;
> }
>
> --
> 2.20.0
>

2020-11-10 08:14:34

by Takashi Sakamoto

Subject: Re: [PATCH] ALSA: firewire: fix comparison to bool warning

On Tue, Nov 10, 2020 at 09:06:29AM +0100, Takashi Iwai wrote:
> On Sat, 07 Nov 2020 17:13:31 +0100,
> [email protected] wrote:
> >
> > From: Kaixu Xia <[email protected]>
> >
> > Fix the following coccicheck warning:
> >
> > ./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool
> >
> > Reported-by: Tosk Robot <[email protected]>
> > Signed-off-by: Kaixu Xia <[email protected]>

The message seems not to reach my mailbox. Anyway:

Acked-by: Takashi Sakamoto <[email protected]>

> Thanks, applied.
>
>
> Takashi
>
> > ---
> > sound/firewire/amdtp-stream.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h
> > index 2ceb57d1d58e..a3daa1f2c1c4 100644
> > --- a/sound/firewire/amdtp-stream.h
> > +++ b/sound/firewire/amdtp-stream.h
> > @@ -270,7 +270,7 @@ static inline bool amdtp_stream_wait_callback(struct amdtp_stream *s,
> > unsigned int timeout)
> > {
> > return wait_event_timeout(s->callback_wait,
> > - s->callbacked == true,
> > + s->callbacked,
> > msecs_to_jiffies(timeout)) > 0;
> > }
> >
> > --
> > 2.20.0

Regards

Takashi Sakamoto