2020-11-11 15:14:35

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v14 1/3] binder: move structs from core file to header file

On Wed, Nov 11, 2020 at 11:02:42PM +0800, Frankie Chang wrote:
> From: "Frankie.Chang" <[email protected]>
>
> Moving all structs to header file makes module more
> extendable, and makes all these structs to be defined
> in the same file.
>
> Signed-off-by: Frankie.Chang <[email protected]>
> Acked-by: Todd Kjos <[email protected]>
> ---
> drivers/android/binder.c | 406 -------------------------------------
> drivers/android/binder_internal.h | 406 +++++++++++++++++++++++++++++++++++++
> 2 files changed, 406 insertions(+), 406 deletions(-)

This, and patch 2/3 was already accepted, right?

I can't do anything with them again :)

thanks,

greg k-h


2020-11-11 16:04:00

by Frankie Chang

[permalink] [raw]
Subject: Re: [PATCH v14 1/3] binder: move structs from core file to header file

On Wed, 2020-11-11 at 16:12 +0100, Greg Kroah-Hartman wrote:
> On Wed, Nov 11, 2020 at 11:02:42PM +0800, Frankie Chang wrote:
> > From: "Frankie.Chang" <[email protected]>
> >
> > Moving all structs to header file makes module more
> > extendable, and makes all these structs to be defined
> > in the same file.
> >
> > Signed-off-by: Frankie.Chang <[email protected]>
> > Acked-by: Todd Kjos <[email protected]>
> > ---
> > drivers/android/binder.c | 406 -------------------------------------
> > drivers/android/binder_internal.h | 406 +++++++++++++++++++++++++++++++++++++
> > 2 files changed, 406 insertions(+), 406 deletions(-)
>
> This, and patch 2/3 was already accepted, right?
>
> I can't do anything with them again :)
>
Oh, okay :)

many thanks
Frankie Chang