2020-11-16 08:53:15

by Zou Wei

Subject: [PATCH -next] mm/page_alloc: Mark some symbols with static keyword

Fix the following sparse warnings:

mm/page_alloc.c:3040:6: warning: symbol '__drain_all_pages' was not declared. Should it be static?
mm/page_alloc.c:6349:6: warning: symbol '__zone_set_pageset_high_and_batch' was not declared. Should it be static?

Signed-off-by: Zou Wei <[email protected]>
---
mm/page_alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 63d8d8b..e7548344 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3037,7 +3037,7 @@ static void drain_local_pages_wq(struct work_struct *work)
* that need the guarantee that every CPU has drained can disable the
* optimizing racy check.
*/
-void __drain_all_pages(struct zone *zone, bool force_all_cpus)
+static void __drain_all_pages(struct zone *zone, bool force_all_cpus)
{
int cpu;

@@ -6346,7 +6346,7 @@ static void pageset_init(struct per_cpu_pageset *p)
pcp->batch = BOOT_PAGESET_BATCH;
}

-void __zone_set_pageset_high_and_batch(struct zone *zone, unsigned long high,
+static void __zone_set_pageset_high_and_batch(struct zone *zone, unsigned long high,
unsigned long batch)
{
struct per_cpu_pageset *p;
--
2.6.2

2020-11-27 17:16:00

by Vlastimil Babka

Subject: Re: [PATCH -next] mm/page_alloc: Mark some symbols with static keyword

On 11/16/20 10:02 AM, Zou Wei wrote:
> Fix the following sparse warnings:
>
> mm/page_alloc.c:3040:6: warning: symbol '__drain_all_pages' was not declared. Should it be static?
> mm/page_alloc.c:6349:6: warning: symbol '__zone_set_pageset_high_and_batch' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <[email protected]>

Acked-by: Vlastimil Babka <[email protected]>

> ---
> mm/page_alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 63d8d8b..e7548344 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3037,7 +3037,7 @@ static void drain_local_pages_wq(struct work_struct *work)
> * that need the guarantee that every CPU has drained can disable the
> * optimizing racy check.
> */
> -void __drain_all_pages(struct zone *zone, bool force_all_cpus)
> +static void __drain_all_pages(struct zone *zone, bool force_all_cpus)
> {
> int cpu;
>
> @@ -6346,7 +6346,7 @@ static void pageset_init(struct per_cpu_pageset *p)
> pcp->batch = BOOT_PAGESET_BATCH;
> }
>
> -void __zone_set_pageset_high_and_batch(struct zone *zone, unsigned long high,
> +static void __zone_set_pageset_high_and_batch(struct zone *zone, unsigned long high,
> unsigned long batch)
> {
> struct per_cpu_pageset *p;
>