2020-11-16 11:37:09

by Srinivasa Rao Mandadapu

[permalink] [raw]
Subject: [PATCH] Asoc: qcom: dts: Change MI2S GPIO configuration to pulldown

From: V Sujith Kumar Reddy <[email protected]>

Change LPASS MI2S gpio configuration to pull down from pull up.

Fixes: 9b72f4e6a3f8 (arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver)

Signed-off-by: V Sujith Kumar Reddy <[email protected]>
Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 802ea0a..b0419e0 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1751,8 +1751,8 @@

pinconf {
pins = "gpio49", "gpio50", "gpio51";
- drive-strength = <8>;
- bias-pull-up;
+ drive-strength = <2>;
+ bias-pull-down;
};
};

@@ -1764,8 +1764,8 @@

pinconf {
pins = "gpio53", "gpio54", "gpio55", "gpio56";
- drive-strength = <8>;
- bias-pull-up;
+ drive-strength = <2>;
+ bias-pull-down;
};
};

@@ -1777,8 +1777,8 @@

pinconf {
pins = "gpio57";
- drive-strength = <8>;
- bias-pull-up;
+ drive-strength = <2>;
+ bias-pull-down;
};
};

--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


2021-02-25 22:24:02

by Doug Anderson

[permalink] [raw]
Subject: Re: [PATCH] Asoc: qcom: dts: Change MI2S GPIO configuration to pulldown

Hi,

On Mon, Nov 16, 2020 at 3:35 AM Srinivasa Rao Mandadapu
<[email protected]> wrote:
>
> From: V Sujith Kumar Reddy <[email protected]>
>
> Change LPASS MI2S gpio configuration to pull down from pull up.
>
> Fixes: 9b72f4e6a3f8 (arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver)
>
> Signed-off-by: V Sujith Kumar Reddy <[email protected]>
> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Should be replaced with:

[PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files
and make pulldown

https://lore.kernel.org/r/20210225141022.2.Id27e7e6f90c29bf623fa4880e18a14ba1dffd2d2@changeid

-Doug