2020-11-18 02:41:09

by Yejune Deng

Subject: [PATCH] phy: amlogic: replace devm_reset_control_array_get()

devm_reset_control_array_get_exclusive() looks more readable

Signed-off-by: Yejune Deng <[email protected]>
---
drivers/phy/amlogic/phy-meson-axg-pcie.c | 2 +-
drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c
index 377ed0d..3204f02 100644
--- a/drivers/phy/amlogic/phy-meson-axg-pcie.c
+++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c
@@ -155,7 +155,7 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
if (IS_ERR(priv->regmap))
return PTR_ERR(priv->regmap);

- priv->reset = devm_reset_control_array_get(dev, false, false);
+ priv->reset = devm_reset_control_array_get_exclusive(dev);
if (IS_ERR(priv->reset))
return PTR_ERR(priv->reset);

diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
index 08e3227..bab6345 100644
--- a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
+++ b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
@@ -418,7 +418,7 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev)
if (ret)
goto err_disable_clk_ref;

- priv->reset = devm_reset_control_array_get(dev, false, false);
+ priv->reset = devm_reset_control_array_get_exclusive(dev);
if (IS_ERR(priv->reset))
return PTR_ERR(priv->reset);

--
1.9.1

2020-11-18 14:58:56

by Philipp Zabel

Subject: Re: [PATCH] phy: amlogic: replace devm_reset_control_array_get()

Hi Yejune,

On Wed, 2020-11-18 at 10:36 +0800, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <[email protected]>
> ---
> drivers/phy/amlogic/phy-meson-axg-pcie.c | 2 +-
> drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> index 377ed0d..3204f02 100644
> --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c
> +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> @@ -155,7 +155,7 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
> if (IS_ERR(priv->regmap))
> return PTR_ERR(priv->regmap);
>
> - priv->reset = devm_reset_control_array_get(dev, false, false);
> + priv->reset = devm_reset_control_array_get_exclusive(dev);
> if (IS_ERR(priv->reset))
> return PTR_ERR(priv->reset);
>
> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> index 08e3227..bab6345 100644
> --- a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> @@ -418,7 +418,7 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev)
> if (ret)
> goto err_disable_clk_ref;
>
> - priv->reset = devm_reset_control_array_get(dev, false, false);
> + priv->reset = devm_reset_control_array_get_exclusive(dev);
> if (IS_ERR(priv->reset))
> return PTR_ERR(priv->reset);
>

Reviewed-by: Philipp Zabel <[email protected]>

regards
Philipp

2020-11-22 21:57:51

by Martin Blumenstingl

Subject: Re: [PATCH] phy: amlogic: replace devm_reset_control_array_get()

On Wed, Nov 18, 2020 at 3:36 AM Yejune Deng <[email protected]> wrote:
>
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>

2020-11-30 11:08:48

by Vinod Koul

Subject: Re: [PATCH] phy: amlogic: replace devm_reset_control_array_get()

On 18-11-20, 10:36, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable

Applied, thanks

--
~Vinod