2020-11-02 12:22:25

by Denys Zagorui

Subject: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make
__FILE__ a relative path") commit. Assembler sources also use __FILE__
macro so this flag should be also apllied to that sources.

Signed-off-by: Denys Zagorui <[email protected]>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index ee2284a5cad2..81e480fc6805 100644
--- a/Makefile
+++ b/Makefile
@@ -946,7 +946,7 @@ KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types)
KBUILD_CFLAGS += $(call cc-option,-Werror=designated-init)

# change __FILE__ to the relative path from the srctree
-KBUILD_CFLAGS += $(call cc-option,-fmacro-prefix-map=$(srctree)/=)
+KBUILD_CPPFLAGS += $(call cc-option,-fmacro-prefix-map=$(srctree)/=)

# ensure -fcf-protection is disabled when using retpoline as it is
# incompatible with -mindirect-branch=thunk-extern
--
2.19.0.dirty

2020-11-09 13:50:29

by Denys Zagorui

Subject: Re: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

> Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make
> __FILE__ a relative path") commit. Assembler sources also use __FILE__
> macro so this flag should be also apllied to that sources.
>
> Signed-off-by: Denys Zagorui <[email protected]>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ee2284a5cad2..81e480fc6805 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -946,7 +946,7 @@ KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types)
> KBUILD_CFLAGS += $(call cc-option,-Werror=designated-init)
>
> # change __FILE__ to the relative path from the srctree
> -KBUILD_CFLAGS += $(call cc-option,-fmacro-prefix-map=$(srctree)/=)
> +KBUILD_CPPFLAGS += $(call cc-option,-fmacro-prefix-map=$(srctree)/=)
>
> # ensure -fcf-protection is disabled when using retpoline as it is
> # incompatible with -mindirect-branch=thunk-extern
> --
> 2.19.0.dirty

ping

2020-11-18 13:07:31

by Denys Zagorui

Subject: Re: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

> ping

Any comments on this ?

Thanks,
Denys

2020-11-20 16:15:15

by Masahiro Yamada

Subject: Re: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

On Wed, Nov 18, 2020 at 10:04 PM Denys Zagorui -X (dzagorui -
GLOBALLOGIC INC at Cisco) <[email protected]> wrote:
>
> > ping
>
> Any comments on this ?
>
> Thanks,
> Denys
>


Sorry for the delay. Now applied.




I fixed the first sentence:

Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make
__FILE__ a relative path") commit.

to

Follow-up to commit a73619a845d5 ("kbuild: use -fmacro-prefix-map to
make __FILE__ a relative path").






> Assembler sources also use __FILE__
> macro so this flag should be also apllied to that sources.

I fixed "apllied" to "applied".




Maybe, "that sources" should be "those sources".





--
Best Regards
Masahiro Yamada

2020-11-23 16:37:36

by Denys Zagorui

Subject: Re: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

> I fixed the first sentence:
>
> Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make
> __FILE__ a relative path") commit.
>
> to
>
> Follow-up to commit a73619a845d5 ("kbuild: use -fmacro-prefix-map to
> make __FILE__ a relative path").
ok, i see


> > Assembler sources also use __FILE__
> > macro so this flag should be also apllied to that sources.
>
> I fixed "apllied" to "applied".
thanks, sorry for this typo



> Maybe, "that sources" should be "those sources".
yes


Thanks,
Denys