2020-11-24 20:18:23

by Tiezhu Yang

Subject: [PATCH] pinctrl: at91-pio4: Make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix build error

If CONFIG_HAS_IOMEM is not set, devm_platform_ioremap_resource() will
be not built in drivers/base/platform.c and then there exists a build
error about undefined reference to "devm_platform_ioremap_resource"
in pinctrl-at91-pio4.c under COMPILE_TEST and CONFIG_PINCTRL_AT91PIO4,
make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix it.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Tiezhu Yang <[email protected]>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 8150953..d132e1a 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -82,6 +82,7 @@ config PINCTRL_AT91
config PINCTRL_AT91PIO4
bool "AT91 PIO4 pinctrl driver"
depends on OF
+ depends on HAS_IOMEM
depends on ARCH_AT91 || COMPILE_TEST
select PINMUX
select GENERIC_PINCONF
--
2.1.0

2020-12-04 08:59:44

by Linus Walleij

Subject: Re: [PATCH] pinctrl: at91-pio4: Make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix build error

On Tue, Nov 24, 2020 at 10:17 AM Tiezhu Yang <[email protected]> wrote:

> If CONFIG_HAS_IOMEM is not set, devm_platform_ioremap_resource() will
> be not built in drivers/base/platform.c and then there exists a build
> error about undefined reference to "devm_platform_ioremap_resource"
> in pinctrl-at91-pio4.c under COMPILE_TEST and CONFIG_PINCTRL_AT91PIO4,
> make PINCTRL_AT91PIO4 depend on HAS_IOMEM to fix it.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Tiezhu Yang <[email protected]>

Patch applied as non-critical fix for v5.11.

Yours,
Linus Walleij