2020-11-28 01:24:58

by Tian Tao

Subject: [PATCH] hwmon: (pwm-fan): Switch to using the new API kobj_to_dev()

fixed the following coccicheck:
drivers/hwmon//pwm-fan.c:152:60-61: WARNING opportunity for kobj_to_dev().

Signed-off-by: Tian Tao <[email protected]>
---
drivers/hwmon/pwm-fan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
index 1f63807..7849011 100644
--- a/drivers/hwmon/pwm-fan.c
+++ b/drivers/hwmon/pwm-fan.c
@@ -149,7 +149,7 @@ static struct attribute *pwm_fan_attrs[] = {
static umode_t pwm_fan_attrs_visible(struct kobject *kobj, struct attribute *a,
int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct pwm_fan_ctx *ctx = dev_get_drvdata(dev);

/* Hide fan_input in case no interrupt is available */
--
2.7.4

2020-11-28 21:58:24

by Guenter Roeck

Subject: Re: [PATCH] hwmon: (pwm-fan): Switch to using the new API kobj_to_dev()

On Sat, Nov 28, 2020 at 09:00:06AM +0800, Tian Tao wrote:
> fixed the following coccicheck:
> drivers/hwmon//pwm-fan.c:152:60-61: WARNING opportunity for kobj_to_dev().
>
> Signed-off-by: Tian Tao <[email protected]>

With the switch to use devm_hwmon_device_register_with_info() instead of
devm_hwmon_device_register_with_groups(), this patch is no longer necessary.
Please see tip of hwmon-next.

Thanks,
Guenter

> ---
> drivers/hwmon/pwm-fan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
> index 1f63807..7849011 100644
> --- a/drivers/hwmon/pwm-fan.c
> +++ b/drivers/hwmon/pwm-fan.c
> @@ -149,7 +149,7 @@ static struct attribute *pwm_fan_attrs[] = {
> static umode_t pwm_fan_attrs_visible(struct kobject *kobj, struct attribute *a,
> int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct pwm_fan_ctx *ctx = dev_get_drvdata(dev);
>
> /* Hide fan_input in case no interrupt is available */