2020-11-30 01:23:51

by Tian Tao

[permalink] [raw]
Subject: [PATCH] leds: lm3533: Switch to using the new API kobj_to_dev()

fixed the following coccicheck:
drivers/leds/leds-lm3533.c:611:60-61: WARNING opportunity for kobj_to_dev().

Signed-off-by: Tian Tao <[email protected]>
---
drivers/leds/leds-lm3533.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c
index b3edee7..9791166 100644
--- a/drivers/leds/leds-lm3533.c
+++ b/drivers/leds/leds-lm3533.c
@@ -608,7 +608,7 @@ static struct attribute *lm3533_led_attributes[] = {
static umode_t lm3533_led_attr_is_visible(struct kobject *kobj,
struct attribute *attr, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct led_classdev *led_cdev = dev_get_drvdata(dev);
struct lm3533_led *led = to_lm3533_led(led_cdev);
umode_t mode = attr->mode;
--
2.7.4


2020-12-17 21:15:41

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] leds: lm3533: Switch to using the new API kobj_to_dev()

On Mon 2020-11-30 09:19:28, Tian Tao wrote:
> fixed the following coccicheck:
> drivers/leds/leds-lm3533.c:611:60-61: WARNING opportunity for kobj_to_dev().
>
> Signed-off-by: Tian Tao <[email protected]>

Thanks, applied.
Pavel


--
http://www.livejournal.com/~pavelmachek


Attachments:
(No filename) (302.00 B)
signature.asc (201.00 B)
Download all attachments