2020-11-18 02:50:40

by Yejune Deng

Subject: [PATCH] soc: amlogic: replace devm_reset_control_array_get()

devm_reset_control_array_get_exclusive() looks more readable

Signed-off-by: Yejune Deng <[email protected]>
---
drivers/soc/amlogic/meson-ee-pwrc.c | 3 +--
drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/amlogic/meson-ee-pwrc.c b/drivers/soc/amlogic/meson-ee-pwrc.c
index ed7d2fb..50bf5d2 100644
--- a/drivers/soc/amlogic/meson-ee-pwrc.c
+++ b/drivers/soc/amlogic/meson-ee-pwrc.c
@@ -413,8 +413,7 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev,
dev_warn(&pdev->dev, "Invalid resets count %d for domain %s\n",
count, dom->desc.name);

- dom->rstc = devm_reset_control_array_get(&pdev->dev, false,
- false);
+ dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
if (IS_ERR(dom->rstc))
return PTR_ERR(dom->rstc);
}
diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
index 8790627..b4615b2 100644
--- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
+++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
@@ -304,7 +304,7 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
return PTR_ERR(regmap_hhi);
}

- rstc = devm_reset_control_array_get(&pdev->dev, false, false);
+ rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
if (IS_ERR(rstc)) {
if (PTR_ERR(rstc) != -EPROBE_DEFER)
dev_err(&pdev->dev, "failed to get reset lines\n");
--
1.9.1

2020-11-18 14:58:06

by Philipp Zabel

Subject: Re: [PATCH] soc: amlogic: replace devm_reset_control_array_get()

Hi Yejune,

On Wed, 2020-11-18 at 10:48 +0800, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <[email protected]>
> ---
> drivers/soc/amlogic/meson-ee-pwrc.c | 3 +--
> drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/amlogic/meson-ee-pwrc.c b/drivers/soc/amlogic/meson-ee-pwrc.c
> index ed7d2fb..50bf5d2 100644
> --- a/drivers/soc/amlogic/meson-ee-pwrc.c
> +++ b/drivers/soc/amlogic/meson-ee-pwrc.c
> @@ -413,8 +413,7 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev,
> dev_warn(&pdev->dev, "Invalid resets count %d for domain %s\n",
> count, dom->desc.name);
>
> - dom->rstc = devm_reset_control_array_get(&pdev->dev, false,
> - false);
> + dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
> if (IS_ERR(dom->rstc))
> return PTR_ERR(dom->rstc);
> }
> diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> index 8790627..b4615b2 100644
> --- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> +++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> @@ -304,7 +304,7 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
> return PTR_ERR(regmap_hhi);
> }
>
> - rstc = devm_reset_control_array_get(&pdev->dev, false, false);
> + rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
> if (IS_ERR(rstc)) {
> if (PTR_ERR(rstc) != -EPROBE_DEFER)
> dev_err(&pdev->dev, "failed to get reset lines\n");

Reviewed-by: Philipp Zabel <[email protected]>

regards
Philipp

2020-11-22 22:00:51

by Martin Blumenstingl

Subject: Re: [PATCH] soc: amlogic: replace devm_reset_control_array_get()

On Wed, Nov 18, 2020 at 3:48 AM Yejune Deng <[email protected]> wrote:
>
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>

2020-12-01 00:09:02

by Kevin Hilman

Subject: Re: [PATCH] soc: amlogic: replace devm_reset_control_array_get()

On Wed, 18 Nov 2020 10:48:20 +0800, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable

Applied, thanks!

[1/1] soc: amlogic: replace devm_reset_control_array_get()
commit: 978d0dbb98c7ce9a5d6897744ac49ac5ff85831e

Best regards,
--
Kevin Hilman <[email protected]>