2020-11-30 11:05:31

by Zou Wei

[permalink] [raw]
Subject: [PATCH -next] x86/platform/uv: Mark some symbols with static keyword

Fix the following sparse warnings:

drivers/platform/x86/uv_sysfs.c:22:13: warning: symbol 'uv_pcibus_kset' was not declared. Should it be static?
drivers/platform/x86/uv_sysfs.c:23:13: warning: symbol 'uv_hubs_kset' was not declared. Should it be static?

Signed-off-by: Zou Wei <[email protected]>
---
drivers/platform/x86/uv_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
index 54c3425..c780a4b 100644
--- a/drivers/platform/x86/uv_sysfs.c
+++ b/drivers/platform/x86/uv_sysfs.c
@@ -19,8 +19,8 @@
#define INVALID_CNODE -1

struct kobject *sgi_uv_kobj;
-struct kset *uv_pcibus_kset;
-struct kset *uv_hubs_kset;
+static struct kset *uv_pcibus_kset;
+static struct kset *uv_hubs_kset;
static struct uv_bios_hub_info *hub_buf;
static struct uv_bios_port_info **port_buf;
static struct uv_hub **uv_hubs;
--
2.6.2


2020-11-30 13:36:19

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH -next] x86/platform/uv: Mark some symbols with static keyword

Hi,

+Cc x86 folks

On 11/30/20 12:11 PM, Zou Wei wrote:
> Fix the following sparse warnings:
>
> drivers/platform/x86/uv_sysfs.c:22:13: warning: symbol 'uv_pcibus_kset' was not declared. Should it be static?
> drivers/platform/x86/uv_sysfs.c:23:13: warning: symbol 'uv_hubs_kset' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <[email protected]>

Since this is a fix to a series merged through the x86/tip tree, this should be merged
to the x86/tip tree too (or I can pick it up after 5.11-rc1).

Here is my ack for merging this through the x86/tip tree:

Acked-by: Hans de Goede <[email protected]>

Regards,

Hans



> ---
> drivers/platform/x86/uv_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
> index 54c3425..c780a4b 100644
> --- a/drivers/platform/x86/uv_sysfs.c
> +++ b/drivers/platform/x86/uv_sysfs.c
> @@ -19,8 +19,8 @@
> #define INVALID_CNODE -1
>
> struct kobject *sgi_uv_kobj;
> -struct kset *uv_pcibus_kset;
> -struct kset *uv_hubs_kset;
> +static struct kset *uv_pcibus_kset;
> +static struct kset *uv_hubs_kset;
> static struct uv_bios_hub_info *hub_buf;
> static struct uv_bios_port_info **port_buf;
> static struct uv_hub **uv_hubs;
>

2020-12-01 11:16:46

by Zou Wei

[permalink] [raw]
Subject: 答复: [PATCH -next] x86/platform/uv: Mark s ome symbols with static keyword

Hi,

Please help to pick it up after 5.11-rc1, thanks a lot.

-----邮件原件-----
发件人: Hans de Goede [mailto:[email protected]]
发送时间: 2020年11月30日 21:31
收件人: Zouwei (Samuel) <[email protected]>; [email protected]; [email protected]
抄送: [email protected]; [email protected]; [email protected]
主题: Re: [PATCH -next] x86/platform/uv: Mark some symbols with static keyword

Hi,

+Cc x86 folks

On 11/30/20 12:11 PM, Zou Wei wrote:
> Fix the following sparse warnings:
>
> drivers/platform/x86/uv_sysfs.c:22:13: warning: symbol 'uv_pcibus_kset' was not declared. Should it be static?
> drivers/platform/x86/uv_sysfs.c:23:13: warning: symbol 'uv_hubs_kset' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <[email protected]>

Since this is a fix to a series merged through the x86/tip tree, this should be merged to the x86/tip tree too (or I can pick it up after 5.11-rc1).

Here is my ack for merging this through the x86/tip tree:

Acked-by: Hans de Goede <[email protected]>

Regards,

Hans



> ---
> drivers/platform/x86/uv_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/uv_sysfs.c
> b/drivers/platform/x86/uv_sysfs.c index 54c3425..c780a4b 100644
> --- a/drivers/platform/x86/uv_sysfs.c
> +++ b/drivers/platform/x86/uv_sysfs.c
> @@ -19,8 +19,8 @@
> #define INVALID_CNODE -1
>
> struct kobject *sgi_uv_kobj;
> -struct kset *uv_pcibus_kset;
> -struct kset *uv_hubs_kset;
> +static struct kset *uv_pcibus_kset;
> +static struct kset *uv_hubs_kset;
> static struct uv_bios_hub_info *hub_buf; static struct
> uv_bios_port_info **port_buf; static struct uv_hub **uv_hubs;
>

Subject: [tip: x86/platform] x86/platform/uv: Make uv_pcibus_kset and uv_hubs_kset static

The following commit has been merged into the x86/platform branch of tip:

Commit-ID: 0c683e9de0c78ee53e220eac9ee3604ca662737a
Gitweb: https://git.kernel.org/tip/0c683e9de0c78ee53e220eac9ee3604ca662737a
Author: Zou Wei <[email protected]>
AuthorDate: Mon, 30 Nov 2020 19:11:53 +08:00
Committer: Borislav Petkov <[email protected]>
CommitterDate: Thu, 03 Dec 2020 08:53:47 +01:00

x86/platform/uv: Make uv_pcibus_kset and uv_hubs_kset static

Fix the following sparse warnings:

drivers/platform/x86/uv_sysfs.c:22:13: warning: symbol \
'uv_pcibus_kset' was not declared. Should it be static?
drivers/platform/x86/uv_sysfs.c:23:13: warning: symbol \
'uv_hubs_kset' was not declared. Should it be static?

Signed-off-by: Zou Wei <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
Acked-by: Hans de Goede <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
drivers/platform/x86/uv_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
index e17ce8c..c27f5ff 100644
--- a/drivers/platform/x86/uv_sysfs.c
+++ b/drivers/platform/x86/uv_sysfs.c
@@ -19,8 +19,8 @@
#define INVALID_CNODE -1

struct kobject *sgi_uv_kobj;
-struct kset *uv_pcibus_kset;
-struct kset *uv_hubs_kset;
+static struct kset *uv_pcibus_kset;
+static struct kset *uv_hubs_kset;
static struct uv_bios_hub_info *hub_buf;
static struct uv_bios_port_info **port_buf;
static struct uv_hub **uv_hubs;