2020-12-09 12:24:23

by David Howells

Subject: [PATCH 07/18] KEYS: remove redundant memset

From: Tom Rix <[email protected]>

Reviewing use of memset in keyctrl_pkey.c

keyctl_pkey_params_get prologue code to set params up

memset(params, 0, sizeof(*params));
params->encoding = "raw";

keyctl_pkey_query has the same prologue
and calls keyctl_pkey_params_get.

So remove the prologue.

Signed-off-by: Tom Rix <[email protected]>
Signed-off-by: David Howells <[email protected]>
---

security/keys/keyctl_pkey.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/security/keys/keyctl_pkey.c b/security/keys/keyctl_pkey.c
index 931d8dfb4a7f..5de0d599a274 100644
--- a/security/keys/keyctl_pkey.c
+++ b/security/keys/keyctl_pkey.c
@@ -166,8 +166,6 @@ long keyctl_pkey_query(key_serial_t id,
struct kernel_pkey_query res;
long ret;

- memset(&params, 0, sizeof(params));
-
ret = keyctl_pkey_params_get(id, _info, &params);
if (ret < 0)
goto error;

2020-12-09 19:12:40

by Ben Boeckel

Subject: Re: [PATCH 07/18] KEYS: remove redundant memset

On Wed, Dec 09, 2020 at 12:15:19 +0000, David Howells wrote:
> From: Tom Rix <[email protected]>
>
> Reviewing use of memset in keyctrl_pkey.c

Typo: `keyctl_pkey.c`

--Ben

2020-12-10 09:25:33

by David Howells

Subject: Re: [PATCH 07/18] KEYS: remove redundant memset

Ben Boeckel <[email protected]> wrote:

> > Reviewing use of memset in keyctrl_pkey.c
>
> Typo: `keyctl_pkey.c`

Fixed, thanks.

David