2020-12-10 11:50:38

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Signed-off-by missing for commit in the tip tree

Hi all,

Commit

46609527577d ("x86, sched: Use midpoint of max_boost and max_P for frequency invariance on AMD EPYC")

is missing a Signed-off-by from its author.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-12-11 00:53:06

by Giovanni Gherdovich

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the tip tree

On Thu, 2020-12-10 at 21:52 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 46609527577d ("x86, sched: Use midpoint of max_boost and max_P for frequency invariance on AMD EPYC")
>
> is missing a Signed-off-by from its author.
>

Hello,

I'm the author of that commit and the missing Signed-off-by is not intentional but
due to a mistake I made. I used the string "------------" in the commit message and
git interpreted it as "drop everything from here onwards", including the
Signed-off-by.

According to the maintainer's preference, I agree to either them adding

Signed-off-by: Giovanni Gherdovich <[email protected]>

or to resend them the patch with a better commit message if they prefer.


Sorry for the inconvenience,
Giovanni Gherdovich




2020-12-11 03:05:25

by Peter Zijlstra

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the tip tree

On Thu, Dec 10, 2020 at 01:50:31PM +0100, Giovanni Gherdovich wrote:
> On Thu, 2020-12-10 at 21:52 +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> > 46609527577d ("x86, sched: Use midpoint of max_boost and max_P for frequency invariance on AMD EPYC")
> >
> > is missing a Signed-off-by from its author.
> >
>
> Hello,
>
> I'm the author of that commit and the missing Signed-off-by is not intentional but
> due to a mistake I made. I used the string "------------" in the commit message and
> git interpreted it as "drop everything from here onwards", including the
> Signed-off-by.
>
> According to the maintainer's preference, I agree to either them adding
>
> Signed-off-by: Giovanni Gherdovich <[email protected]>

Hurmph, I'd have to rebase that branch to fix this.. mingo?