2020-12-14 12:35:05

by Bongsu Jeon

Subject: [PATCH net-next] nfc: s3fwrn5: Release the nfc firmware

From: Bongsu Jeon <[email protected]>

add the code to release the nfc firmware when the firmware image size is
wrong.

Signed-off-by: Bongsu Jeon <[email protected]>
---
drivers/nfc/s3fwrn5/firmware.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c
index 4b5352e2b915..b70737b3070e 100644
--- a/drivers/nfc/s3fwrn5/firmware.c
+++ b/drivers/nfc/s3fwrn5/firmware.c
@@ -293,8 +293,10 @@ int s3fwrn5_fw_request_firmware(struct s3fwrn5_fw_info *fw_info)
if (ret < 0)
return ret;

- if (fw->fw->size < S3FWRN5_FW_IMAGE_HEADER_SIZE)
+ if (fw->fw->size < S3FWRN5_FW_IMAGE_HEADER_SIZE) {
+ release_firmware(fw->fw);
return -EINVAL;
+ }

memcpy(fw->date, fw->fw->data + 0x00, 12);
fw->date[12] = '\0';
--
2.17.1

2020-12-14 15:51:43

by Krzysztof Kozlowski

Subject: Re: [PATCH net-next] nfc: s3fwrn5: Release the nfc firmware

On Sun, Dec 13, 2020 at 06:58:50PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon <[email protected]>
>
> add the code to release the nfc firmware when the firmware image size is
> wrong.

s/add/Add/
s/nfc/NFC/

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2020-12-15 03:33:32

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] nfc: s3fwrn5: Release the nfc firmware

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sun, 13 Dec 2020 18:58:50 +0900 you wrote:
> From: Bongsu Jeon <[email protected]>
>
> add the code to release the nfc firmware when the firmware image size is
> wrong.
>
> Signed-off-by: Bongsu Jeon <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] nfc: s3fwrn5: Release the nfc firmware
https://git.kernel.org/netdev/net-next/c/a4485baefa1e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html