On 2020-12-16 21:16, Stanley Chu wrote:
> Hi,
> This series cleans up and refactors clk-scaling feature, and shall not
> change any functionality.
>
> This series is based on Can's series "Three changes related with UFS
> clock scaling" in 5.10/scsi-fixes branch in Martin's tree.
>
Hi Stanley,
Thanks for noticing my changes, will you review them?
I see customers manipulte UFS scaling related sysfs
nodes more often than before, so we may want to fix it asap.
Regards,
Can Guo.
> However this series may not be required to be merged to 5.10. The
> choice of base branch is simply making these patches easy to be
> reviewed because this series is based on clk-scaling fixes by Can. If
> this series is decided not being merged to 5.10, then I would rebase
> it to 5.11/scsi-queue.
>
> Changes since v1:
> - Refactor ufshcd_clk_scaling_suspend() in patch [3/4]
> - Change function name from ufshcd_clk_scaling_pm() to
> ufshcd_clk_scaling_suspend() in patch [3/4]
> - Refine patch titles
>
> Stanley Chu (4):
> scsi: ufs: Refactor cancelling clkscaling works
> scsi: ufs: Remove redundant null checking of devfreq instance
> scsi: ufs: Cleanup and refactor clk-scaling feature
> scsi: ufs: Fix build warning by incorrect function description
>
> drivers/scsi/ufs/ufshcd.c | 90 +++++++++++++++++++--------------------
> 1 file changed, 43 insertions(+), 47 deletions(-)
Hi Can,
On Fri, 2020-12-18 at 14:20 +0800, Can Guo wrote:
> On 2020-12-16 21:16, Stanley Chu wrote:
> > Hi,
> > This series cleans up and refactors clk-scaling feature, and shall not
> > change any functionality.
> >
> > This series is based on Can's series "Three changes related with UFS
> > clock scaling" in 5.10/scsi-fixes branch in Martin's tree.
> >
>
> Hi Stanley,
>
> Thanks for noticing my changes, will you review them?
> I see customers manipulte UFS scaling related sysfs
> nodes more often than before, so we may want to fix it asap.
I have gave my review tag in all patches in this series : )
Thanks,
Stanley Chu
>
> Regards,
>
> Can Guo.
>
> > However this series may not be required to be merged to 5.10. The
> > choice of base branch is simply making these patches easy to be
> > reviewed because this series is based on clk-scaling fixes by Can. If
> > this series is decided not being merged to 5.10, then I would rebase
> > it to 5.11/scsi-queue.
> >
> > Changes since v1:
> > - Refactor ufshcd_clk_scaling_suspend() in patch [3/4]
> > - Change function name from ufshcd_clk_scaling_pm() to
> > ufshcd_clk_scaling_suspend() in patch [3/4]
> > - Refine patch titles
> >
> > Stanley Chu (4):
> > scsi: ufs: Refactor cancelling clkscaling works
> > scsi: ufs: Remove redundant null checking of devfreq instance
> > scsi: ufs: Cleanup and refactor clk-scaling feature
> > scsi: ufs: Fix build warning by incorrect function description
> >
> > drivers/scsi/ufs/ufshcd.c | 90 +++++++++++++++++++--------------------
> > 1 file changed, 43 insertions(+), 47 deletions(-)
On 2020-12-18 14:24, Stanley Chu wrote:
> Hi Can,
>
> On Fri, 2020-12-18 at 14:20 +0800, Can Guo wrote:
>> On 2020-12-16 21:16, Stanley Chu wrote:
>> > Hi,
>> > This series cleans up and refactors clk-scaling feature, and shall not
>> > change any functionality.
>> >
>> > This series is based on Can's series "Three changes related with UFS
>> > clock scaling" in 5.10/scsi-fixes branch in Martin's tree.
>> >
>>
>> Hi Stanley,
>>
>> Thanks for noticing my changes, will you review them?
>> I see customers manipulte UFS scaling related sysfs
>> nodes more often than before, so we may want to fix it asap.
>
> I have gave my review tag in all patches in this series : )
>
> Thanks,
> Stanley Chu
>
Hi Stanley,
oops, just saw it - I opened the wrong series.
I will push a new version which incorporates your comments soon.
Since the new changes would only be some words in ufshcd.h, so you
won't need to rebase.
Thanks,
Can Guo.
>>
>> Regards,
>>
>> Can Guo.
>>
>> > However this series may not be required to be merged to 5.10. The
>> > choice of base branch is simply making these patches easy to be
>> > reviewed because this series is based on clk-scaling fixes by Can. If
>> > this series is decided not being merged to 5.10, then I would rebase
>> > it to 5.11/scsi-queue.
>> >
>> > Changes since v1:
>> > - Refactor ufshcd_clk_scaling_suspend() in patch [3/4]
>> > - Change function name from ufshcd_clk_scaling_pm() to
>> > ufshcd_clk_scaling_suspend() in patch [3/4]
>> > - Refine patch titles
>> >
>> > Stanley Chu (4):
>> > scsi: ufs: Refactor cancelling clkscaling works
>> > scsi: ufs: Remove redundant null checking of devfreq instance
>> > scsi: ufs: Cleanup and refactor clk-scaling feature
>> > scsi: ufs: Fix build warning by incorrect function description
>> >
>> > drivers/scsi/ufs/ufshcd.c | 90 +++++++++++++++++++--------------------
>> > 1 file changed, 43 insertions(+), 47 deletions(-)