2020-12-18 08:17:24

by Kiran Gunda

Subject: [PATCH V4 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l

Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
found on SC7180 based platforms.

Signed-off-by: Kiran Gunda <[email protected]>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++
drivers/mfd/qcom-spmi-pmic.c | 4 ++++
2 files changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index e458dd1..2acddbc 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -58,6 +58,8 @@ patternProperties:
- qcom,pm8005
- qcom,pm660l
- qcom,pm660
+ - qcom,pm6150l
+ - qcom,pm6150

- enum:
- qcom,spmi-pmic
diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
index a35d5cf..78e9084 100644
--- a/drivers/mfd/qcom-spmi-pmic.c
+++ b/drivers/mfd/qcom-spmi-pmic.c
@@ -38,6 +38,8 @@
#define PM8005_SUBTYPE 0x18
#define PM660L_SUBTYPE 0x1A
#define PM660_SUBTYPE 0x1B
+#define PM6150L_SUBTYPE 0x1F
+#define PM6150_SUBTYPE 0x28

static const struct of_device_id pmic_spmi_id_table[] = {
{ .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE },
@@ -61,6 +63,8 @@ static const struct of_device_id pmic_spmi_id_table[] = {
{ .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE },
{ .compatible = "qcom,pm660l", .data = (void *)PM660L_SUBTYPE },
{ .compatible = "qcom,pm660", .data = (void *)PM660_SUBTYPE },
+ { .compatible = "qcom,pm6150l", .data = (void *)PM6150L_SUBTYPE },
+ { .compatible = "qcom,pm6150", .data = (void *)PM6150_SUBTYPE },
{ }
};

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2020-12-19 23:50:28

by Stephen Boyd

Subject: Re: [PATCH V4 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l

Quoting Kiran Gunda (2020-12-18 00:14:52)
> Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
> found on SC7180 based platforms.
>
> Signed-off-by: Kiran Gunda <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2020-12-21 08:48:37

by Lee Jones

Subject: Re: [PATCH V4 2/2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l

On Fri, 18 Dec 2020, Kiran Gunda wrote:

> Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
> found on SC7180 based platforms.
>
> Signed-off-by: Kiran Gunda <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++
> drivers/mfd/qcom-spmi-pmic.c | 4 ++++
> 2 files changed, 6 insertions(+)

I can't apply this until the file has been converted.

In the mean time:

For my own reference (apply this as-is to your sign-off block):

Acked-for-MFD-by: Lee Jones <[email protected]>

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog