2020-12-18 12:55:29

by Geert Uytterhoeven

Subject: [PATCH] clk: vc5: Use "idt,voltage-microvolt" instead of "idt,voltage-microvolts"

Commit 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to
yaml") accidentally changed "idt,voltage-microvolts" to
"idt,voltage-microvolt" in the DT bindings, while the driver still used
the former.

Update the driver to match the bindings, as
Documentation/devicetree/bindings/property-units.txt actually recommends
using "microvolt".

Fixes: 260249f929e81d3d ("clk: vc5: Enable addition output configurations of the Versaclock")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
There are no upstream users yet, but they are planned for v5.12, so I
think this should be in v5.11-rc1.

Thanks!
---
drivers/clk/clk-versaclock5.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
index c90460e7ef2153fe..43db67337bc06824 100644
--- a/drivers/clk/clk-versaclock5.c
+++ b/drivers/clk/clk-versaclock5.c
@@ -739,8 +739,8 @@ static int vc5_update_power(struct device_node *np_output,
{
u32 value;

- if (!of_property_read_u32(np_output,
- "idt,voltage-microvolts", &value)) {
+ if (!of_property_read_u32(np_output, "idt,voltage-microvolt",
+ &value)) {
clk_out->clk_output_cfg0_mask |= VC5_CLK_OUTPUT_CFG0_PWR_MASK;
switch (value) {
case 1800000:
--
2.25.1

2020-12-18 23:25:10

by Luca Ceresoli

Subject: Re: [PATCH] clk: vc5: Use "idt,voltage-microvolt" instead of "idt,voltage-microvolts"

Hi Geert,

On 18/12/20 13:52, Geert Uytterhoeven wrote:
> Commit 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to
> yaml") accidentally changed "idt,voltage-microvolts" to
> "idt,voltage-microvolt" in the DT bindings, while the driver still used
> the former.
>
> Update the driver to match the bindings, as
> Documentation/devicetree/bindings/property-units.txt actually recommends
> using "microvolt".
>
> Fixes: 260249f929e81d3d ("clk: vc5: Enable addition output configurations of the Versaclock")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> There are no upstream users yet, but they are planned for v5.12, so I
> think this should be in v5.11-rc1.
>
> Thanks!
> ---
> drivers/clk/clk-versaclock5.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
> index c90460e7ef2153fe..43db67337bc06824 100644
> --- a/drivers/clk/clk-versaclock5.c
> +++ b/drivers/clk/clk-versaclock5.c
> @@ -739,8 +739,8 @@ static int vc5_update_power(struct device_node *np_output,
> {
> u32 value;
>
> - if (!of_property_read_u32(np_output,
> - "idt,voltage-microvolts", &value)) {
> + if (!of_property_read_u32(np_output, "idt,voltage-microvolt",
> + &value)) {

Reviewed-by: Luca Ceresoli <[email protected]>

Now the example in the bindings needs the same fix. I guess you doing it
in your "Miscellaneous fixes and improvements" v2 series, otherwise I
can do that.

Thanks,
--
Luca

2020-12-19 11:34:16

by Geert Uytterhoeven

Subject: Re: [PATCH] clk: vc5: Use "idt,voltage-microvolt" instead of "idt,voltage-microvolts"

Hi Luca,

On Fri, Dec 18, 2020 at 11:18 PM Luca Ceresoli <[email protected]> wrote:
> On 18/12/20 13:52, Geert Uytterhoeven wrote:
> > Commit 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to
> > yaml") accidentally changed "idt,voltage-microvolts" to
> > "idt,voltage-microvolt" in the DT bindings, while the driver still used
> > the former.
> >
> > Update the driver to match the bindings, as
> > Documentation/devicetree/bindings/property-units.txt actually recommends
> > using "microvolt".
> >
> > Fixes: 260249f929e81d3d ("clk: vc5: Enable addition output configurations of the Versaclock")
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > ---
> > There are no upstream users yet, but they are planned for v5.12, so I
> > think this should be in v5.11-rc1.
> >
> > Thanks!
> > ---
> > drivers/clk/clk-versaclock5.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
> > index c90460e7ef2153fe..43db67337bc06824 100644
> > --- a/drivers/clk/clk-versaclock5.c
> > +++ b/drivers/clk/clk-versaclock5.c
> > @@ -739,8 +739,8 @@ static int vc5_update_power(struct device_node *np_output,
> > {
> > u32 value;
> >
> > - if (!of_property_read_u32(np_output,
> > - "idt,voltage-microvolts", &value)) {
> > + if (!of_property_read_u32(np_output, "idt,voltage-microvolt",
> > + &value)) {
>
> Reviewed-by: Luca Ceresoli <[email protected]>

Thanks!

> Now the example in the bindings needs the same fix. I guess you doing it
> in your "Miscellaneous fixes and improvements" v2 series, otherwise I
> can do that.

Yep, planned for v2.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-12-20 00:11:15

by Stephen Boyd

Subject: Re: [PATCH] clk: vc5: Use "idt,voltage-microvolt" instead of "idt,voltage-microvolts"

Quoting Geert Uytterhoeven (2020-12-18 04:52:53)
> Commit 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to
> yaml") accidentally changed "idt,voltage-microvolts" to
> "idt,voltage-microvolt" in the DT bindings, while the driver still used
> the former.
>
> Update the driver to match the bindings, as
> Documentation/devicetree/bindings/property-units.txt actually recommends
> using "microvolt".
>
> Fixes: 260249f929e81d3d ("clk: vc5: Enable addition output configurations of the Versaclock")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---

Applied to clk-next