2020-12-22 11:24:49

by Yoshihiro Shimoda

Subject: [PATCH v5 05/12] regulator: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is silimar chip with BD9571MWV.
Note that we don't support voltage rails VD{09,18,25,33} by this
driver on BD9574. The VD09 voltage could be read from PMIC but that
is not supported by this commit.

Signed-off-by: Yoshihiro Shimoda <[email protected]>
Reviewed-by: Matti Vaittinen <[email protected]>
---
drivers/regulator/bd9571mwv-regulator.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c
index 42b6a70..7b0cd08 100644
--- a/drivers/regulator/bd9571mwv-regulator.c
+++ b/drivers/regulator/bd9571mwv-regulator.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
/*
- * ROHM BD9571MWV-M regulator driver
+ * ROHM BD9571MWV-M and BD9574MWF-M regulator driver
*
* Copyright (C) 2017 Marek Vasut <[email protected]>
*
@@ -9,6 +9,7 @@
* NOTE: VD09 is missing
*/

+#include <linux/mfd/rohm-generic.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/platform_device.h>
@@ -277,6 +278,7 @@ static int bd9571mwv_regulator_probe(struct platform_device *pdev)
struct regulator_dev *rdev;
unsigned int val;
int i;
+ enum rohm_chip_type chip = platform_get_device_id(pdev)->driver_data;

bdreg = devm_kzalloc(&pdev->dev, sizeof(*bdreg), GFP_KERNEL);
if (!bdreg)
@@ -292,6 +294,9 @@ static int bd9571mwv_regulator_probe(struct platform_device *pdev)
config.regmap = bdreg->regmap;

for (i = 0; i < ARRAY_SIZE(regulators); i++) {
+ /* BD9574MWF supports DVFS only */
+ if (chip == ROHM_CHIP_TYPE_BD9574 && regulators[i].id != DVFS)
+ continue;
rdev = devm_regulator_register(&pdev->dev, &regulators[i],
&config);
if (IS_ERR(rdev)) {
@@ -339,7 +344,8 @@ static int bd9571mwv_regulator_probe(struct platform_device *pdev)
}

static const struct platform_device_id bd9571mwv_regulator_id_table[] = {
- { "bd9571mwv-regulator", },
+ { "bd9571mwv-regulator", ROHM_CHIP_TYPE_BD9571 },
+ { "bd9574mwf-regulator", ROHM_CHIP_TYPE_BD9574 },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(platform, bd9571mwv_regulator_id_table);
--
2.7.4

2020-12-23 09:16:43

by Sergei Shtylyov

Subject: Re: [PATCH v5 05/12] regulator: bd9571mwv: Add BD9574MWF support

On 22.12.2020 14:22, Yoshihiro Shimoda wrote:

> Add support for BD9574MWF which is silimar chip with BD9571MWV.

Similar (again)? :-)

> Note that we don't support voltage rails VD{09,18,25,33} by this
> driver on BD9574. The VD09 voltage could be read from PMIC but that
> is not supported by this commit.
>
> Signed-off-by: Yoshihiro Shimoda <[email protected]>
> Reviewed-by: Matti Vaittinen <[email protected]>
[...]

MBR, Sergei

2020-12-23 09:25:13

by Yoshihiro Shimoda

Subject: RE: [PATCH v5 05/12] regulator: bd9571mwv: Add BD9574MWF support

Hi Sergei,

> From: Sergei Shtylyov, Sent: Wednesday, December 23, 2020 6:15 PM
>
> On 22.12.2020 14:22, Yoshihiro Shimoda wrote:
>
> > Add support for BD9574MWF which is silimar chip with BD9571MWV.
>
> Similar (again)? :-)

Thank you for pointed it out! I'll fix this and patch 8/12.

Best regards,
Yoshihiro Shimoda