2020-09-30 02:24:09

by Crystal Guo

[permalink] [raw]
Subject: [v6,1/3] dt-binding: reset-controller: mediatek: add YAML schemas

Add a YAML documentation for Mediatek, which uses ti reset-controller
driver directly. The TI reset controller provides a common reset
management, and is suitable for Mediatek SoCs.

Signed-off-by: Crystal Guo <[email protected]>
---
.../bindings/reset/mediatek-syscon-reset.yaml | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml

diff --git a/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
new file mode 100644
index 000000000000..7871550c3c69
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/reset/mediatek-syscon-reset.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek Reset Controller
+
+maintainers:
+ - Crystal Guo <[email protected]>
+
+description:
+ The bindings describe the reset-controller for Mediatek SoCs,
+ which is based on TI reset controller. For more detail, please
+ visit Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.
+
+properties:
+ compatible:
+ const: mediatek,syscon-reset
+
+ '#reset-cells':
+ const: 1
+
+ mediatek,reset-bits:
+ description: >
+ Contains the reset control register information, please refer to
+ Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.
+
+required:
+ - compatible
+ - '#reset-cells'
+ - mediatek,reset-bits
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/reset/ti-syscon.h>
+ infracfg: infracfg@10001000 {
+ compatible = "mediatek,mt8192-infracfg", "syscon", "simple-mfd";
+ reg = <0 0x10001000>;
+ #clock-cells = <1>;
+
+ infracfg_rst: reset-controller {
+ compatible = "mediatek,syscon-reset";
+ #reset-cells = <1>;
+ mediatek,reset-bits = <
+ 0x140 15 0x144 15 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE)
+ >;
+ };
+ };
--
2.18.0


2020-10-14 21:42:43

by Crystal Guo

[permalink] [raw]
Subject: Re: [v6,1/3] dt-binding: reset-controller: mediatek: add YAML schemas

Hi Maintainers,

Gentle ping for this patch set.

Many thanks
Crystal

On Wed, 2020-09-30 at 10:21 +0800, Crystal Guo wrote:
> Add a YAML documentation for Mediatek, which uses ti reset-controller
> driver directly. The TI reset controller provides a common reset
> management, and is suitable for Mediatek SoCs.
>
> Signed-off-by: Crystal Guo <[email protected]>
> ---
> .../bindings/reset/mediatek-syscon-reset.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
>
> diff --git a/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> new file mode 100644
> index 000000000000..7871550c3c69
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/mediatek-syscon-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek Reset Controller
> +
> +maintainers:
> + - Crystal Guo <[email protected]>
> +
> +description:
> + The bindings describe the reset-controller for Mediatek SoCs,
> + which is based on TI reset controller. For more detail, please
> + visit Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.
> +
> +properties:
> + compatible:
> + const: mediatek,syscon-reset
> +
> + '#reset-cells':
> + const: 1
> +
> + mediatek,reset-bits:
> + description: >
> + Contains the reset control register information, please refer to
> + Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.
> +
> +required:
> + - compatible
> + - '#reset-cells'
> + - mediatek,reset-bits
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/reset/ti-syscon.h>
> + infracfg: infracfg@10001000 {
> + compatible = "mediatek,mt8192-infracfg", "syscon", "simple-mfd";
> + reg = <0 0x10001000>;
> + #clock-cells = <1>;
> +
> + infracfg_rst: reset-controller {
> + compatible = "mediatek,syscon-reset";
> + #reset-cells = <1>;
> + mediatek,reset-bits = <
> + 0x140 15 0x144 15 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE)
> + >;
> + };
> + };

2020-11-11 08:30:37

by Stanley Chu

[permalink] [raw]
Subject: Re: [v6,1/3] dt-binding: reset-controller: mediatek: add YAML schemas

Hi Matthias, Philipp, Suman,

Since almost one month pending with this patch series, just a gentle
ping that would you have further suggestions on this series?

We are looking for this series being merged soon.

Thanks

On Wed, 2020-10-14 at 21:30 +0800, Crystal Guo wrote:
> Hi Maintainers,
>
> Gentle ping for this patch set.
>
> Many thanks
> Crystal
>
> On Wed, 2020-09-30 at 10:21 +0800, Crystal Guo wrote:
> > Add a YAML documentation for Mediatek, which uses ti reset-controller
> > driver directly. The TI reset controller provides a common reset
> > management, and is suitable for Mediatek SoCs.
> >
> > Signed-off-by: Crystal Guo <[email protected]>
> > ---
> > .../bindings/reset/mediatek-syscon-reset.yaml | 51 +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> > new file mode 100644
> > index 000000000000..7871550c3c69
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> > @@ -0,0 +1,51 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/reset/mediatek-syscon-reset.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek Reset Controller
> > +
> > +maintainers:
> > + - Crystal Guo <[email protected]>
> > +
> > +description:
> > + The bindings describe the reset-controller for Mediatek SoCs,
> > + which is based on TI reset controller. For more detail, please
> > + visit Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,syscon-reset
> > +
> > + '#reset-cells':
> > + const: 1
> > +
> > + mediatek,reset-bits:
> > + description: >
> > + Contains the reset control register information, please refer to
> > + Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.
> > +
> > +required:
> > + - compatible
> > + - '#reset-cells'
> > + - mediatek,reset-bits
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/reset/ti-syscon.h>
> > + infracfg: infracfg@10001000 {
> > + compatible = "mediatek,mt8192-infracfg", "syscon", "simple-mfd";
> > + reg = <0 0x10001000>;
> > + #clock-cells = <1>;
> > +
> > + infracfg_rst: reset-controller {
> > + compatible = "mediatek,syscon-reset";
> > + #reset-cells = <1>;
> > + mediatek,reset-bits = <
> > + 0x140 15 0x144 15 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE)
> > + >;
> > + };
> > + };
>
>

2020-12-03 07:44:13

by Philipp Zabel

[permalink] [raw]
Subject: Re: [v6,1/3] dt-binding: reset-controller: mediatek: add YAML schemas

Hi,

On Wed, 2020-09-30 at 10:21 +0800, Crystal Guo wrote:
> Add a YAML documentation for Mediatek, which uses ti reset-controller
> driver directly. The TI reset controller provides a common reset
> management, and is suitable for Mediatek SoCs.
>
> Signed-off-by: Crystal Guo <[email protected]>
> ---
> .../bindings/reset/mediatek-syscon-reset.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
>
> diff --git a/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> new file mode 100644
> index 000000000000..7871550c3c69
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/mediatek-syscon-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek Reset Controller
> +
> +maintainers:
> + - Crystal Guo <[email protected]>
> +
> +description:
> + The bindings describe the reset-controller for Mediatek SoCs,
> + which is based on TI reset controller. For more detail, please
> + visit Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.
> +
> +properties:
> + compatible:
> + const: mediatek,syscon-reset
> +
> + '#reset-cells':
> + const: 1
> +
> + mediatek,reset-bits:
> + description: >
> + Contains the reset control register information, please refer to
> + Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.

I would really like some input from Rob on this, in v4 he asked not to
repeat 'ti,reset-bits'.

regards
Philipp

2020-12-26 09:10:06

by Crystal Guo

[permalink] [raw]
Subject: Re: [v6,1/3] dt-binding: reset-controller: mediatek: add YAML schemas

On Thu, 2020-12-03 at 15:41 +0800, Philipp Zabel wrote:
> Hi,
>
> On Wed, 2020-09-30 at 10:21 +0800, Crystal Guo wrote:
> > Add a YAML documentation for Mediatek, which uses ti reset-controller
> > driver directly. The TI reset controller provides a common reset
> > management, and is suitable for Mediatek SoCs.
> >
> > Signed-off-by: Crystal Guo <[email protected]>
> > ---
> > .../bindings/reset/mediatek-syscon-reset.yaml | 51 +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> > new file mode 100644
> > index 000000000000..7871550c3c69
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/reset/mediatek-syscon-reset.yaml
> > @@ -0,0 +1,51 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/reset/mediatek-syscon-reset.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek Reset Controller
> > +
> > +maintainers:
> > + - Crystal Guo <[email protected]>
> > +
> > +description:
> > + The bindings describe the reset-controller for Mediatek SoCs,
> > + which is based on TI reset controller. For more detail, please
> > + visit Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,syscon-reset
> > +
> > + '#reset-cells':
> > + const: 1
> > +
> > + mediatek,reset-bits:
> > + description: >
> > + Contains the reset control register information, please refer to
> > + Documentation/devicetree/bindings/reset/ti-syscon-reset.txt.
>
> I would really like some input from Rob on this, in v4 he asked not to
> repeat 'ti,reset-bits'.
>
> regards
> Philipp


Hi Rob,

Can you give some suggestions on this document
"mediatek-syscon-reset.yaml", many thanks~

regards
Crystal Guo