2020-12-11 14:36:21

by Sudeep Holla

Subject: [PATCH v2] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs

Since at91_soc_init is called unconditionally from atmel_soc_device_init,
we get the following warning on all non AT91 SoCs:
" AT91: Could not find identification node"

Fix the same by filtering with allowed AT91 SoC list.

Cc: Nicolas Ferre <[email protected]>
Cc: Alexandre Belloni <[email protected]>
Cc: Ludovic Desroches <[email protected]>
Signed-off-by: Sudeep Holla <[email protected]>
---
drivers/soc/atmel/soc.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

v1->v2:
- Updated the allowed list as suggested by Alexandre

diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
index 55a1f57a4d8c..2dc86728b132 100644
--- a/drivers/soc/atmel/soc.c
+++ b/drivers/soc/atmel/soc.c
@@ -265,8 +265,20 @@ struct soc_device * __init at91_soc_init(const struct at91_soc *socs)
return soc_dev;
}

+static const struct of_device_id at91_soc_allowed_list[] __initconst = {
+ { .compatible = "atmel,at91rm9200", },
+ { .compatible = "atmel,at91sam9", },
+ { .compatible = "atmel,sama5", },
+ { .compatible = "atmel,samv7", }
+};
+
static int __init atmel_soc_device_init(void)
{
+ struct device_node *np = of_find_node_by_path("/");
+
+ if (!of_match_node(at91_soc_allowed_list, np))
+ return 0;
+
at91_soc_init(socs);

return 0;
--
2.25.1

2020-12-28 17:00:12

by Alexandre Belloni

Subject: Re: [PATCH v2] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs

On Fri, 11 Dec 2020 13:58:46 +0000, Sudeep Holla wrote:
> Since at91_soc_init is called unconditionally from atmel_soc_device_init,
> we get the following warning on all non AT91 SoCs:
> " AT91: Could not find identification node"
>
> Fix the same by filtering with allowed AT91 SoC list.

Applied, thanks!

[1/1] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs
commit: 960ddf70cc11024e6e9dac206316d0160e00a77d

Best regards,
--
Alexandre Belloni <[email protected]>