2020-12-29 01:34:12

by Tim Harvey

Subject: [PATCH] mfd: gateworks-gsc: fix interrupt type

The Gateworks System Controller has an active-low interrupt.
Fix the interrupt request type.

Fixes: d85234994b2f ("mfd: Add Gateworks System Controller core driver")

Cc: <[email protected]>
Signed-off-by: Tim Harvey <[email protected]>
---
drivers/mfd/gateworks-gsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/gateworks-gsc.c b/drivers/mfd/gateworks-gsc.c
index 576da62..d878767 100644
--- a/drivers/mfd/gateworks-gsc.c
+++ b/drivers/mfd/gateworks-gsc.c
@@ -234,7 +234,7 @@ static int gsc_probe(struct i2c_client *client)

ret = devm_regmap_add_irq_chip(dev, gsc->regmap, client->irq,
IRQF_ONESHOT | IRQF_SHARED |
- IRQF_TRIGGER_FALLING, 0,
+ IRQF_TRIGGER_LOW, 0,
&gsc_irq_chip, &irq_data);
if (ret)
return ret;
--
2.7.4

2021-01-14 09:54:24

by Lee Jones

Subject: Re: [PATCH] mfd: gateworks-gsc: fix interrupt type

On Mon, 28 Dec 2020, Tim Harvey wrote:

> The Gateworks System Controller has an active-low interrupt.
> Fix the interrupt request type.
>
> Fixes: d85234994b2f ("mfd: Add Gateworks System Controller core driver")
>
> Cc: <[email protected]>
> Signed-off-by: Tim Harvey <[email protected]>
> ---
> drivers/mfd/gateworks-gsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog