2021-01-11 12:46:36

by Abaci Team

Subject: [PATCH] scsi: mpt3sas: style: Simplify bool comparison

Fix the following coccicheck warning:
./drivers/scsi/mpt3sas/mpt3sas_base.c:2424:5-20: WARNING: Comparison of
0/1 to bool variable

Signed-off-by: YANG LI <[email protected]>
Reported-by: Abaci Robot<[email protected]>
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 6e23dc3..f5582c8 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -2505,8 +2505,8 @@ static u32 base_mod64(u64 dividend, u32 divisor)
}

/* Check if we need to build a native SG list. */
- if (base_is_prp_possible(ioc, pcie_device,
- scmd, sges_left) == 0) {
+ if (!base_is_prp_possible(ioc, pcie_device,
+ scmd, sges_left)) {
/* We built a native SG list, just return. */
goto out;
}
--
1.8.3.1

2021-01-23 03:03:52

by Martin K. Petersen

Subject: Re: [PATCH] scsi: mpt3sas: style: Simplify bool comparison

Yang,

> Fix the following coccicheck warning:
> ./drivers/scsi/mpt3sas/mpt3sas_base.c:2424:5-20: WARNING: Comparison of
> 0/1 to bool variable

Applied to 5.12/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2021-01-27 21:10:19

by Martin K. Petersen

Subject: Re: [PATCH] scsi: mpt3sas: style: Simplify bool comparison

On Mon, 11 Jan 2021 16:54:13 +0800, YANG LI wrote:

> Fix the following coccicheck warning:
> ./drivers/scsi/mpt3sas/mpt3sas_base.c:2424:5-20: WARNING: Comparison of
> 0/1 to bool variable

Applied to 5.12/scsi-queue, thanks!

[1/1] scsi: mpt3sas: style: Simplify bool comparison
https://git.kernel.org/mkp/scsi/c/bfb3f00c0613

--
Martin K. Petersen Oracle Linux Engineering