2021-01-11 09:39:03

by Abaci Team

Subject: [PATCH] arm64: mte: style: Simplify bool comparison

Fix the following coccicheck warning:
./tools/testing/selftests/arm64/mte/check_buffer_fill.c:84:12-35:
WARNING: Comparison to bool

Signed-off-by: YANG LI <[email protected]>
Reported-by: Abaci Robot<[email protected]>
---
tools/testing/selftests/arm64/mte/check_buffer_fill.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/arm64/mte/check_buffer_fill.c b/tools/testing/selftests/arm64/mte/check_buffer_fill.c
index c9fa141..75fc482 100644
--- a/tools/testing/selftests/arm64/mte/check_buffer_fill.c
+++ b/tools/testing/selftests/arm64/mte/check_buffer_fill.c
@@ -81,7 +81,7 @@ static int check_buffer_underflow_by_byte(int mem_type, int mode,
last_index = 0;
/* Set some value in tagged memory and make the buffer underflow */
for (j = sizes[i] - 1; (j >= -underflow_range) &&
- (cur_mte_cxt.fault_valid == false); j--) {
+ (!cur_mte_cxt.fault_valid); j--) {
ptr[j] = '1';
last_index = j;
}
--
1.8.3.1

2021-01-20 14:24:19

by Will Deacon

Subject: Re: [PATCH] arm64: mte: style: Simplify bool comparison

On Mon, 11 Jan 2021 17:35:37 +0800, YANG LI wrote:
> Fix the following coccicheck warning:
> ./tools/testing/selftests/arm64/mte/check_buffer_fill.c:84:12-35:
> WARNING: Comparison to bool

Applied to arm64 (for-next/selftests), thanks!

[1/1] arm64: mte: style: Simplify bool comparison
https://git.kernel.org/arm64/c/dd313a2653d4

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev