2021-01-12 10:53:14

by Zou Wei

Subject: [PATCH -next] phy: mediatek: Mark mtk_mipi_tx_driver with static keyword

Fix the following sparse warning:

drivers/phy/mediatek/phy-mtk-mipi-dsi.c:237:24: warning: symbol 'mtk_mipi_tx_driver' was not declared. Should it be static?

Signed-off-by: Zou Wei <[email protected]>
---
drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
index 18c4812..eeb357b 100644
--- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
+++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
@@ -234,7 +234,7 @@ static const struct of_device_id mtk_mipi_tx_match[] = {
{ },
};

-struct platform_driver mtk_mipi_tx_driver = {
+static struct platform_driver mtk_mipi_tx_driver = {
.probe = mtk_mipi_tx_probe,
.remove = mtk_mipi_tx_remove,
.driver = {
--
2.6.2

2021-01-13 14:17:25

by Vinod Koul

Subject: Re: [PATCH -next] phy: mediatek: Mark mtk_mipi_tx_driver with static keyword

On 12-01-21, 09:38, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/phy/mediatek/phy-mtk-mipi-dsi.c:237:24: warning: symbol 'mtk_mipi_tx_driver' was not declared. Should it be static?

Applied, thanks

--
~Vinod

2021-01-14 02:12:14

by Chunfeng Yun

Subject: Re: [PATCH -next] phy: mediatek: Mark mtk_mipi_tx_driver with static keyword

On Tue, 2021-01-12 at 09:38 +0800, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/phy/mediatek/phy-mtk-mipi-dsi.c:237:24: warning: symbol 'mtk_mipi_tx_driver' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> index 18c4812..eeb357b 100644
> --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> @@ -234,7 +234,7 @@ static const struct of_device_id mtk_mipi_tx_match[] = {
> { },
> };
>
> -struct platform_driver mtk_mipi_tx_driver = {
> +static struct platform_driver mtk_mipi_tx_driver = {
> .probe = mtk_mipi_tx_probe,
> .remove = mtk_mipi_tx_remove,
> .driver = {

Acked-by: Chunfeng Yun <[email protected]>

Thanks