2021-01-12 12:33:45

by Abaci Team

Subject: [PATCH v2] rtw88: Simplify bool comparison

Fix the following coccicheck warning:
./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:
Comparison of 0/1 to bool variable

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: YANG LI <[email protected]>
---
Changes in v2:

make "rtw88:" as subject prefix

drivers/net/wireless/realtek/rtw88/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c
index 19fc2d8..948cb79 100644
--- a/drivers/net/wireless/realtek/rtw88/debug.c
+++ b/drivers/net/wireless/realtek/rtw88/debug.c
@@ -800,7 +800,7 @@ static ssize_t rtw_debugfs_set_coex_enable(struct file *filp,
}

mutex_lock(&rtwdev->mutex);
- coex->manual_control = enable == 0;
+ coex->manual_control = !enable;
mutex_unlock(&rtwdev->mutex);

return count;
--
1.8.3.1

2021-01-14 17:29:51

by Kalle Valo

Subject: Re: [PATCH v2] rtw88: Simplify bool comparison

YANG LI <[email protected]> wrote:

> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:
> Comparison of 0/1 to bool variable
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: YANG LI <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

d3a78c7a9daa rtw88: Simplify bool comparison

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches