2021-01-12 11:50:59

by Abaci Team

[permalink] [raw]
Subject: [PATCH] scsi: lpfc: style: Simplify bool comparison

Fix the following coccicheck warning:
./drivers/scsi/lpfc/lpfc_bsg.c:5392:5-29: WARNING: Comparison to bool

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: YANG LI <[email protected]>
---
drivers/scsi/lpfc/lpfc_bsg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index eed6ea5..b974d39 100644
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -5376,9 +5376,9 @@ static int lpfc_bsg_check_cmd_access(struct lpfc_hba *phba,

ras_fwlog = &phba->ras_fwlog;

- if (ras_fwlog->ras_hwsupport == false)
+ if (!ras_fwlog->ras_hwsupport)
return -EACCES;
- else if (ras_fwlog->ras_enabled == false)
+ else if (!ras_fwlog->ras_enabled)
return -EPERM;
else
return 0;
--
1.8.3.1


2021-01-12 18:03:45

by James Smart

[permalink] [raw]
Subject: Re: [PATCH] scsi: lpfc: style: Simplify bool comparison



On 1/12/2021 12:24 AM, YANG LI wrote:
> Fix the following coccicheck warning:
> ./drivers/scsi/lpfc/lpfc_bsg.c:5392:5-29: WARNING: Comparison to bool
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: YANG LI <[email protected]>
> ---
> drivers/scsi/lpfc/lpfc_bsg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>

Reviewed-by:  James Smart <[email protected]>

-- james

Attachments:
smime.p7s (4.07 kB)
S/MIME Cryptographic Signature

2021-01-15 05:51:47

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: lpfc: style: Simplify bool comparison

On Tue, 12 Jan 2021 16:24:53 +0800, YANG LI wrote:

> Fix the following coccicheck warning:
> ./drivers/scsi/lpfc/lpfc_bsg.c:5392:5-29: WARNING: Comparison to bool

Applied to 5.12/scsi-queue, thanks!

[1/1] scsi: lpfc: style: Simplify bool comparison
https://git.kernel.org/mkp/scsi/c/af0c94afc0c4

--
Martin K. Petersen Oracle Linux Engineering