2021-01-25 07:23:00

by Abaci Team

Subject: [PATCH] ALSA: hda: Assign boolean values to a bool variable

Fix the following coccicheck warnings:

./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of
0/1 to bool variable.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Zhong <[email protected]>
---
sound/pci/hda/hda_intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 5a50d3a..24e9762 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2304,7 +2304,7 @@ static int azx_probe_continue(struct azx *chip)

/* HSW/BDW controllers need this power */
if (CONTROLLER_IN_GPU(pci))
- hda->need_i915_power = 1;
+ hda->need_i915_power = true;
}

/* Request display power well for the HDA controller or codec. For
--
1.8.3.1

2021-01-25 12:42:51

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda: Assign boolean values to a bool variable

On Mon, 25 Jan 2021 08:17:27 +0100,
Jiapeng Zhong wrote:
>
> Fix the following coccicheck warnings:
>
> ./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of
> 0/1 to bool variable.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Zhong <[email protected]>

Thanks, applied now.

But if you have some more similar changes, please try to convert at
once instead of submitting each change infrequently. It's getting
annoying now, as the change itself hardly helps improving the
readability or code quality in general, although there is no strong
reason to object it.


Takashi