2021-01-26 06:01:39

by chenlei0x

Subject: [PATCH] blk: wbt: remove unused parameter from wbt_should_throttle

From: Lei Chen <[email protected]>

The first parameter rwb is not used for this function.
So just remove it.

Signed-off-by: Lei Chen <[email protected]>
---
block/blk-wbt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index 0321ca8..42aed01 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -518,7 +518,7 @@ static void __wbt_wait(struct rq_wb *rwb, enum wbt_flags wb_acct,
rq_qos_wait(rqw, &data, wbt_inflight_cb, wbt_cleanup_cb);
}

-static inline bool wbt_should_throttle(struct rq_wb *rwb, struct bio *bio)
+static inline bool wbt_should_throttle(struct bio *bio)
{
switch (bio_op(bio)) {
case REQ_OP_WRITE:
@@ -545,7 +545,7 @@ static enum wbt_flags bio_to_wbt_flags(struct rq_wb *rwb, struct bio *bio)

if (bio_op(bio) == REQ_OP_READ) {
flags = WBT_READ;
- } else if (wbt_should_throttle(rwb, bio)) {
+ } else if (wbt_should_throttle(bio)) {
if (current_is_kswapd())
flags |= WBT_KSWAPD;
if (bio_op(bio) == REQ_OP_DISCARD)
--
1.8.3.1

2021-01-27 19:50:32

by Jens Axboe

Subject: Re: [PATCH] blk: wbt: remove unused parameter from wbt_should_throttle

On 1/25/21 4:27 AM, [email protected] wrote:
> From: Lei Chen <[email protected]>
>
> The first parameter rwb is not used for this function.
> So just remove it.

Applied, thanks.

--
Jens Axboe