2021-01-26 01:31:57

by Zou Wei

Subject: [PATCH -next] usb: gadget: Remove unused including <linux/version.h>

Fix the following versioncheck warning:

drivers/usb/gadget/udc/aspeed-vhub/hub.c:33:1: unused including <linux/version.h>

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/usb/gadget/udc/aspeed-vhub/hub.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
index 396a7d8..b192d57 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
@@ -30,7 +30,6 @@
#include <linux/regmap.h>
#include <linux/dma-mapping.h>
#include <linux/bcd.h>
-#include <linux/version.h>
#include <linux/usb.h>
#include <linux/usb/hcd.h>

--
2.6.2

2021-01-27 06:17:07

by Greg Kroah-Hartman

Subject: Re: [PATCH -next] usb: gadget: Remove unused including <linux/version.h>

On Mon, Jan 25, 2021 at 08:41:32PM +0800, Zou Wei wrote:
> Fix the following versioncheck warning:
>
> drivers/usb/gadget/udc/aspeed-vhub/hub.c:33:1: unused including <linux/version.h>
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/usb/gadget/udc/aspeed-vhub/hub.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> index 396a7d8..b192d57 100644
> --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
> @@ -30,7 +30,6 @@
> #include <linux/regmap.h>
> #include <linux/dma-mapping.h>
> #include <linux/bcd.h>
> -#include <linux/version.h>
> #include <linux/usb.h>
> #include <linux/usb/hcd.h>

You didn't test this patch either :(

Your script is not correct...

greg k-h