2021-01-29 07:42:26

by Yang Li

Subject: [PATCH] phy: cpcap-usb: Simplify bool conversion

Fix the following coccicheck warning:
./drivers/phy/motorola/phy-cpcap-usb.c:146:31-36: WARNING: conversion to
bool not needed here

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/phy/motorola/phy-cpcap-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c
index 4728e2b..6ee478b 100644
--- a/drivers/phy/motorola/phy-cpcap-usb.c
+++ b/drivers/phy/motorola/phy-cpcap-usb.c
@@ -143,7 +143,7 @@ static bool cpcap_usb_vbus_valid(struct cpcap_phy_ddata *ddata)

error = iio_read_channel_processed(ddata->vbus, &value);
if (error >= 0)
- return value > 3900 ? true : false;
+ return value > 3900;

dev_err(ddata->dev, "error reading VBUS: %i\n", error);

--
1.8.3.1

2021-02-06 10:10:46

by Vinod Koul

Subject: Re: [PATCH] phy: cpcap-usb: Simplify bool conversion

On 29-01-21, 15:38, Yang Li wrote:
> Fix the following coccicheck warning:
> ./drivers/phy/motorola/phy-cpcap-usb.c:146:31-36: WARNING: conversion to
> bool not needed here

Applied, thanks

--
~Vinod