2021-02-02 06:40:56

by Yang Li

Subject: [PATCH] psci: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/firmware/psci/psci.c:141:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/firmware/psci/psci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
index f5fc429..35b355e 100644
--- a/drivers/firmware/psci/psci.c
+++ b/drivers/firmware/psci/psci.c
@@ -138,7 +138,7 @@ static int psci_to_linux_errno(int errno)
return -EINVAL;
case PSCI_RET_DENIED:
return -EPERM;
- };
+ }

return -EINVAL;
}
--
1.8.3.1

2021-04-28 10:15:11

by Lorenzo Pieralisi

Subject: Re: [PATCH] psci: remove unneeded semicolon

On Tue, Feb 02, 2021 at 02:37:52PM +0800, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/firmware/psci/psci.c:141:2-3: Unneeded semicolon

Nit: subject should read "psci: Remove unneeded semicolon"

> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/firmware/psci/psci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Please send a v2 and address it to Mark, me and [email protected] so
that they can pick it up.

Acked-by: Lorenzo Pieralisi <[email protected]>

> diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
> index f5fc429..35b355e 100644
> --- a/drivers/firmware/psci/psci.c
> +++ b/drivers/firmware/psci/psci.c
> @@ -138,7 +138,7 @@ static int psci_to_linux_errno(int errno)
> return -EINVAL;
> case PSCI_RET_DENIED:
> return -EPERM;
> - };
> + }
>
> return -EINVAL;
> }
> --
> 1.8.3.1
>

2021-04-28 10:19:30

by Sudeep Holla

Subject: Re: [PATCH] psci: remove unneeded semicolon

On Wed, Apr 28, 2021 at 10:41:30AM +0100, Lorenzo Pieralisi wrote:
> On Tue, Feb 02, 2021 at 02:37:52PM +0800, Yang Li wrote:
> > Eliminate the following coccicheck warning:
> > ./drivers/firmware/psci/psci.c:141:2-3: Unneeded semicolon
>
> Nit: subject should read "psci: Remove unneeded semicolon"
>
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Yang Li <[email protected]>
> > ---
> > drivers/firmware/psci/psci.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Please send a v2 and address it to Mark, me and [email protected] so
> that they can pick it up.
>

Though I assume they still check [email protected], [email protected] is new
and more preferred these days. I just checked MAINTAINERS entry to be
sure and I see only [email protected]. So please add [email protected] to the
list, may be it gets quicker attention than the other ????.

--
Regards,
Sudeep